Closed Bug 819825 Opened 7 years ago Closed 7 years ago

some ICE/STUN negotiations hang or crash on Android in mbslen()

Categories

(Core :: WebRTC, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: dmose, Assigned: dmose)

References

(Blocks 1 open bug)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][qa-])

Attachments

(1 file, 1 obsolete file)

After apply the build patches for Android in the dependency tree for bug 750869, the ICE unittest hangs or crashes in mbslen.  The problem is that setlocale() on Android returns null.

The calling code actually isn't really caring about this function, excitingly.  Here's a patch that makes things run further, but it would be good to verify that's impossible/hard to get UTF8 before we just punt.
Whiteboard: [WebRTC][blocking-webrtc-]
This strikes me as somewhat more maintainable/readable code than adding another ifdef clause.  And it makes the ice unit tests pass.
Attachment #690253 - Attachment is obsolete: true
Comment on attachment 691901 [details] [diff] [review]
version2: null-check set-locale, and abort the function if that fails

r=abr over IRC
Attachment #691901 - Flags: review+
Pushed to mozilla-inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9a891c0a6e7

in-testsuite+, as this was caught by ice_unittest, and this fix makes that test pass.
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/b9a891c0a6e7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Whiteboard: [WebRTC][blocking-webrtc-] → [WebRTC][blocking-webrtc-][qa-]
You need to log in before you can comment on or make changes to this bug.