The default bug view has changed. See this FAQ.

some ICE/STUN negotiations hang or crash on Android in mbslen()

RESOLVED FIXED in mozilla20

Status

()

Core
WebRTC
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

(Blocks: 1 bug)

Trunk
mozilla20
ARM
Android
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC][blocking-webrtc-][qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Created attachment 690253 [details] [diff] [review]
WIP patch 1: abort the function rather than trying to handle a null return from setlocale()

After apply the build patches for Android in the dependency tree for bug 750869, the ICE unittest hangs or crashes in mbslen.  The problem is that setlocale() on Android returns null.

The calling code actually isn't really caring about this function, excitingly.  Here's a patch that makes things run further, but it would be good to verify that's impossible/hard to get UTF8 before we just punt.

Updated

4 years ago
Whiteboard: [WebRTC][blocking-webrtc-]
(Assignee)

Comment 1

4 years ago
Created attachment 691901 [details] [diff] [review]
version2: null-check set-locale, and abort the function if that fails

This strikes me as somewhat more maintainable/readable code than adding another ifdef clause.  And it makes the ice unit tests pass.
Attachment #690253 - Attachment is obsolete: true
(Assignee)

Comment 2

4 years ago
Comment on attachment 691901 [details] [diff] [review]
version2: null-check set-locale, and abort the function if that fails

r=abr over IRC
Attachment #691901 - Flags: review+
(Assignee)

Comment 3

4 years ago
Try server build:

https://tbpl.mozilla.org/?tree=Try&rev=6b62c415dd7f
(Assignee)

Comment 4

4 years ago
Pushed to mozilla-inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9a891c0a6e7

in-testsuite+, as this was caught by ice_unittest, and this fix makes that test pass.
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/b9a891c0a6e7
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20

Updated

4 years ago
Whiteboard: [WebRTC][blocking-webrtc-] → [WebRTC][blocking-webrtc-][qa-]
You need to log in before you can comment on or make changes to this bug.