819827 - Preprocessing of the actual channel removed by bug 721165

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

Preprocessing of the actual update channel was added as a fallback in case the channel preferences file was removed (this has happened due to 3rd party software) so we can still update clients. This needs to be added back.

The relevant change is in attachment #659758 [details] [diff] [review] in bug 721165. Search for @MOZ_UPDATE_CHANNEL@

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Sounds like we need to fix this for 18?

Comment 2

[Robert Strong (they/them - no direct email)]

That would be a good thing imo

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 691098 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 721165 
User impact if declined: updates may fail for users whose channel prefs file was removed (apparently this happens to people somehow?)
Testing completed (on m-c, etc.): none
Risk to taking this patch (and alternatives if risky): it only affects the fallback value - getting that wrong is no worse than the current state. Other issues it could cause (making the file invalid JS somehow) would blow tests up quite visibly.
String or UUID changes made by this patch: none

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/31ff0e486fb5

Comment 6

[Alex Keybl [:akeybl]]

Comment on attachment 691098 [details] [diff] [review]
patch

Given the very low risk profile here, let's land on Aurora/Beta.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eaab25f5b98e
https://hg.mozilla.org/releases/mozilla-beta/rev/baf41da2066b

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/baf41da2066b