Preprocessing of the actual update channel was added as a fallback in case the channel preferences file was removed (this has happened due to 3rd party software) so we can still update clients. This needs to be added back. The relevant change is in attachment #659758 [details] [diff] [review] in bug 721165. Search for @MOZ_UPDATE_CHANNEL@
That would be a good thing imo
Assignee: andres → gavin.sharp
Status: NEW → ASSIGNED
Attachment #691098 - Flags: review?(robert.bugzilla)
Attachment #691098 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 691098 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 721165 User impact if declined: updates may fail for users whose channel prefs file was removed (apparently this happens to people somehow?) Testing completed (on m-c, etc.): none Risk to taking this patch (and alternatives if risky): it only affects the fallback value - getting that wrong is no worse than the current state. Other issues it could cause (making the file invalid JS somehow) would blow tests up quite visibly. String or UUID changes made by this patch: none
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment on attachment 691098 [details] [diff] [review] patch Given the very low risk profile here, let's land on Aurora/Beta.
You need to log in before you can comment on or make changes to this bug.