819831 - B2G STK: update numeric constants in nsIDOMIccManager to string constants

Status: RESOLVED WONTFIX

(Core :: DOM: Device Interfaces, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

See Bug 744714 comment 80, as Jonas suggested we'd update those numeric constants in nsIDOMIccManager to string constants.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Current XPIDL doesn't support string constant, see Bug 443316.
If we are going to use webidl, we can use
http://dev.w3.org/2006/webapi/WebIDL/#idl-enums

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Hi Hsin-Yi, Vivien,

I'd work on this bug, but it'll introduce an incompatible API change between Gaia and Ril. How do we best make this change? Shall we have a flag day, or are there better options?

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> Hi Hsin-Yi, Vivien,
> 
> I'd work on this bug, but it'll introduce an incompatible API change between
> Gaia and Ril. How do we best make this change? Shall we have a flag day, or
> are there better options?

Hi Thomas,

To avoid breaking any features, the way we usually do is providing a patch for backward-compatibility on gaia first. Then land a API change patch. Afterwards, removing backward-compatibility part.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #3)
> (In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> > Hi Hsin-Yi, Vivien,
> > 
> > I'd work on this bug, but it'll introduce an incompatible API change between
> > Gaia and Ril. How do we best make this change? Shall we have a flag day, or
> > are there better options?
> 
> Hi Thomas,
> 
> To avoid breaking any features, the way we usually do is providing a patch
> for backward-compatibility on gaia first. Then land a API change patch.
> Afterwards, removing backward-compatibility part.

What Hsin-Yi says. This is a long time issue we have because of our 2 repos :/