Closed Bug 819831 Opened 7 years ago Closed 2 years ago

B2G STK: update numeric constants in nsIDOMIccManager to string constants

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED WONTFIX

People

(Reporter: allstars.chh, Unassigned)

References

Details

See Bug 744714 comment 80, as Jonas suggested we'd update those numeric constants in nsIDOMIccManager to string constants.
Current XPIDL doesn't support string constant, see Bug 443316.
If we are going to use webidl, we can use
http://dev.w3.org/2006/webapi/WebIDL/#idl-enums
Hi Hsin-Yi, Vivien,

I'd work on this bug, but it'll introduce an incompatible API change between Gaia and Ril. How do we best make this change? Shall we have a flag day, or are there better options?
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Flags: needinfo?(htsai)
Flags: needinfo?(21)
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> Hi Hsin-Yi, Vivien,
> 
> I'd work on this bug, but it'll introduce an incompatible API change between
> Gaia and Ril. How do we best make this change? Shall we have a flag day, or
> are there better options?

Hi Thomas,

To avoid breaking any features, the way we usually do is providing a patch for backward-compatibility on gaia first. Then land a API change patch. Afterwards, removing backward-compatibility part.
Flags: needinfo?(htsai)
(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #3)
> (In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #2)
> > Hi Hsin-Yi, Vivien,
> > 
> > I'd work on this bug, but it'll introduce an incompatible API change between
> > Gaia and Ril. How do we best make this change? Shall we have a flag day, or
> > are there better options?
> 
> Hi Thomas,
> 
> To avoid breaking any features, the way we usually do is providing a patch
> for backward-compatibility on gaia first. Then land a API change patch.
> Afterwards, removing backward-compatibility part.

What Hsin-Yi says. This is a long time issue we have because of our 2 repos :/
Flags: needinfo?(21)
Assignee: tzimmermann → nobody
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.