Always treat empty images as being background-attachment:scroll

RESOLVED FIXED in mozilla20

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mattwoodrow, Unassigned)

Tracking

unspecified
mozilla20
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 690264 [details] [diff] [review]
Always treat empty images as being background-attachment:scroll

This was returning a background positioning area relative to the viewport, but we don't fix the display item when it doesn't have an image.

DLBI was then attempting to shift the positioning area to compensate for scroll changes, and we detecting that the background moved.

A nicer fix would be to split nsDisplayCanvasBackground into separate color/image items, and then not even create the image items if they are empty.
Attachment #690264 - Flags: review?(roc)
(Reporter)

Updated

6 years ago
Attachment #690264 - Attachment is patch: true
It should be pretty easy to use paint_listener.js to write a testcase for this. Please do.
https://hg.mozilla.org/mozilla-central/rev/222b76f9fa95
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.