Closed
Bug 819837
Opened 12 years ago
Closed 12 years ago
Always treat empty images as being background-attachment:scroll
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: mattwoodrow, Unassigned)
Details
Attachments
(1 file)
|
1.28 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
This was returning a background positioning area relative to the viewport, but we don't fix the display item when it doesn't have an image. DLBI was then attempting to shift the positioning area to compensate for scroll changes, and we detecting that the background moved. A nicer fix would be to split nsDisplayCanvasBackground into separate color/image items, and then not even create the image items if they are empty.
Attachment #690264 -
Flags: review?(roc)
|
Reporter | |
Updated•12 years ago
|
Attachment #690264 -
Attachment is patch: true
Attachment #690264 -
Flags: review?(roc) → review+
|
|
Reporter | |
Comment 1•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/222b76f9fa95
It should be pretty easy to use paint_listener.js to write a testcase for this. Please do.
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/222b76f9fa95
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•