819898 - [SMS] shouldn't try to send a message without a recipient

Status: VERIFIED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[Tim Taubert [:ttaubert] (inactive)]

STR:

1) Open the SMS app
2) Click '+' to create a new message
3) Click the message field and type something.
4) Click 'Send'

Expected:
The user should probably see an error message saying that we need a recipient.

Actual:
The message gets sent and the throbber keeps spinning. Also the following error is in the console:

E/GeckoConsole( 1470): [JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIDOMMozSmsManager.send]" {file: "app://sms.gaiamobile.org/js/sms.js" line: 195}]

Comment 1

[Casey Yee]

Ayman, can you please advise on the intended behavior.

Comment 2

[Borja Salguero [:borjasalguero]]

Attachment: PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 3

[ayman maat :maat]

Would advise to disable the 'send' button until content is added to both:

1) the 'To' field (the recipient), and
2) the message field

From a UX perspective error prevention is always a far superior experience than error handling.

Comment 4

[Borja Salguero [:borjasalguero]]

Cool! Thanks for the tip. Im gonna add it to the PR. Thanks!

Comment 7

[Nick Davidson]

"send" button is disabled if no information entered to both:

1) the 'To' field (the recipient), and
2) the message field contact field.