Updatable plugin test hits the network

RESOLVED FIXED in mozilla20



6 years ago
6 years ago


(Reporter: neil, Assigned: mcsmurf)


Dependency tree / graph

Firefox Tracking Flags

(Not tracked)



(1 attachment, 1 obsolete attachment)



6 years ago
test18a() tests that the updatable plugin should open up the plugin check page. However it uses the real plugin check page on mozilla.org when it should use a test page created for the purpose, or indeed just some random page that is served as part of the test harnses would do.
Created attachment 690493 [details] [diff] [review]

Running locally with wireshark, I see no evidence that this actually does hit the network (the test closes the tab as soon as it opens), but since this is dependent on other behavior that may change in the future, this is probably a good thing to fix. I think the easiest thing to do is what the safe browsing tests do.

bsmedberg - asking for review as you're a build/ peer. Let me know if someone else would be better suited.
Attachment #690493 - Flags: review?(benjamin)

Comment 2

6 years ago
Actually it probably only hits the network for the SeaMonkey version of the plugin test ;) there the test waits for the onshow() event before closing the tab (as the UI works a bit different, so we did it that way).
Can we easily change the URL used for plugin check in the test harness? Looks like it's just a matter of setting plugins.update.url in automation.py.in?

That would be preferable to making changes to server-hosts, since that has the potential to affect a bunch of other tests.

Comment 4

6 years ago
Comment on attachment 690493 [details] [diff] [review]

Yes, this seems like an odd choice if it only affects one test. Going to clear the review for now, please rerequest review if changing the pref is not an option for some reason.
Attachment #690493 - Flags: review?(benjamin)

Comment 5

6 years ago
Created attachment 693058 [details] [diff] [review]
Better patch

Looks like the correct fix to me, changing the pref does the right thing.
Attachment #690493 - Attachment is obsolete: true
Attachment #693058 - Flags: review?(benjamin)


6 years ago
Attachment #693058 - Flags: review?(benjamin) → review+

Comment 6

6 years ago
Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f9ea385ca51f
Assignee: nobody → bugzilla
Target Milestone: --- → mozilla20
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.