819974 - [Apps] Allow to cancel hosted app download

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect, P1)

Description

[Fernando Jiménez Moreno [:ferjm]]

We need the ability to cancel hosted app installations in order to fully implement the Gaia app install specs.
More info in Bug 816128.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Blocker of a blocker, so I guess this one should be bb+ too.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

I'd like to do more tests before asking for r?

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

It seems to be working properly. I'm just updating the patch to remove some trailing white spaces.

This patch won't land until Bug 819971 does.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 691389 [details] [diff] [review]
v1

Review of attachment 691389 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/apps/src/Webapps.jsm
@@ +866,5 @@
>        return;
>      }
> +
> +    if (download.cacheUpdate) {
> +      // Cancell hosted app download.

Nit: Cancel

@@ +869,5 @@
> +    if (download.cacheUpdate) {
> +      // Cancell hosted app download.
> +      download.cacheUpdate.cancel();
> +    } else if (download.channel) {
> +      // Cancell packaged app download.

ditto

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v2

I had to modify the patch because of the changes that I've made for Bug 819971. Now we don't use the nsIOfflineCacheUpdateObserver::STATE_CANCELLED state, but we reuse the STATE_ERROR one.

Fabrice, I won't ask you for r? again to not spam your request queue, but feel free to take a look at the patch again :).

Comment 8

[Dietrich Ayala (:dietrich)]

Driver retriage: QA, please ensure scenario in bug 816128 is covered. They are 100% identical, but want to ensure we're not missing anything.

Also, can this land now?

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

We have to wait for Bug 819971 to land. Hopefully that will happen today.

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ba2f2f5fb6b2

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ba2f2f5fb6b2

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9f16f87d783a
https://hg.mozilla.org/releases/mozilla-b2g18/rev/1a054d2478f0

Comment 13

[Jason Smith [:jsmith]]

Verified - I've confirmed I cancel a hosted app download preloading appcache.