820100 - [e.me] browser context shouldn't be shared between two apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Alexandre Poirot [:ochameau]]

Bug 807438 introduced some regressions.

Test case:
1) go to Facebook
2) close facebook
3) go to twitter
4) open footer

Current result:
See back button enabled, click back -> go to Facebook (but the back should be disabled)

Expected result:
Back button disabled

One other unexpected result is that when you open twitter, you may see facebook appear while twitter is loading.

Comment 1

[Cristian Rodriguez (:crdlc)]

Hi Alexandre, do you have any update? thanks

Comment 2

[Alexandre Poirot [:ochameau]]

Sorry, I went back to my original team.
So I don't think that I'll have time to fix that anytime soon.

Comment 3

[Cristian Rodriguez (:crdlc)]

I will take a look to this, thanks

Comment 4

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to crdlc from comment #4)
> Created attachment 710098 [details]
> Patch v1

I don't see why the fix works. See github comments. Could you please give some explanation?

Comment 6

[Cristian Rodriguez (:crdlc)]

here the explanation:

https://github.com/mozilla-b2g/gaia/pull/7956/files#r2890774

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 710098 [details]
Patch v1

I could r+ the fix but please provide a unit test.
This issue is not emergent, so I guess we have some time to learn writing a test.

Please give a unit test about wrapper if possible.
Window Manager itself now is not unit testable...I am working on this.

Comment 8

[Cristian Rodriguez (:crdlc)]

ok working on it

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 710098 [details]
Patch v1

r=me if next time you have unit test as we discussed offline.

Comment 10

[Cristian Rodriguez (:crdlc)]

Comment on attachment 710098 [details]
Patch v1

IMHO sharing history of navigation among apps and what users can view the last webapp while the current is loading is ugly. I mean, this is not a blocker but the experience is not good. Nominating... so you can decide if it could go in v1. Thanks

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: bad user experience
Testing completed: in my device
Risk to taking this patch (and alternatives if risky): low

Comment 11

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/d5713e58c38ea772d940ce7d0155eb2b9406aa20

Comment 12

[Daniel Coloma:dcoloma]

As Cristian, says, sharing navigation history across apps is quite weird, based on the risk/reward I think we should take this one to v1-train.

Comment 13

[Cristian Rodriguez (:crdlc)]

Everything.me guys have tested it on master and they said to me that it is working fine

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 710098 [details]
Patch v1

Approving this tested fix for v1-train uplift.

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: e2d1b046ecbf3f79a18e8bae44b51fe61f111421

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: Bugs fixed on b2g18 after 1/25 merge to v1.0 branch are fixed on v1.0.1 branch.