Closed
Bug 820104
Opened 13 years ago
Closed 12 years ago
unnecessary inefficient trigonometry for computing waveforms for dialer
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(blocking-basecamp:-)
RESOLVED
INVALID
| blocking-basecamp | - |
People
(Reporter: djf, Assigned: djf)
Details
The dialer computes the waveform for every tone it generates from scratch with no trig lookup tables or other clever hacks.
For every 150ms of sound it plays, it is making 2400 calls to Math.sin(). I actually have no idea what kind of impact that has on the CPU. Maybe it is trivial, but we could make this much more efficient.
I'm going to nominate this as blocking and assign it to myself because I have fun doing this kind of math.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → dflanagan
blocking-basecamp: --- → ?
|
||
Comment 1•13 years ago
|
||
Triage: BB-. Please renominate if there is any major user impact.
blocking-basecamp: ? → -
|
||
Comment 2•12 years ago
|
||
Is this still a problem now that we use the web audio api (and that we might switch to pre-generated sounds)?
Flags: needinfo?(etienne)
|
||
Comment 3•12 years ago
|
||
(In reply to Anthony Ricaud (:rik) from comment #2)
> Is this still a problem now that we use the web audio api (and that we might
> switch to pre-generated sounds)?
In anyway this is not an issue anymore, since we have the cool oscillator nodes in WebAudio :)
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: needinfo?(etienne)
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•