820165 - b2g_build.py looking for platform.ini in a different place than it should be

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

https://tbpl.mozilla.org/php/getParsedLog.php?id=17795026&tree=Firefox&full=1#error0

The script is looking for b2g's platform.ini here:

$builder_dir/build/out/target/product/panda-gaia-central/system/b2g/platform.ini

but that path should be using the PRODUCT_OUT android build system variable to locate the file.  This variable is set on the build machines to:

$builder_dir/build/out/target/product/panda

Which means that it should be looking for:

$builder_dir/build/out/target/product/panda/system/b2g/platform.ini

It looks like b2g_build.py is substituting the releng name of the platform where it should be the android build system name of the platform ("panda").

Comment 1

[Aki Sasaki (not active)]

I think we do that in three places:
http://hg.mozilla.org/build/mozharness/file/a6817d229248/scripts/b2g_build.py#l119
http://hg.mozilla.org/build/mozharness/file/a6817d229248/scripts/b2g_build.py#l177
http://hg.mozilla.org/build/mozharness/file/a6817d229248/scripts/b2g_build.py#l472

Now all we need is a map of panda-gaia-central -> panda.

Comment 2

[Aki Sasaki (not active)]

The current solution being considered is

1) rename panda-gaia-central to panda_gaia-central
2) go by self.config['target'].split('_')[0]

Is there a way to get PRODUCT_OUT directly?

Comment 3

[Aki Sasaki (not active)]

Also

--target panda --b2g-config-dir panda-gaia-central

would work.

Comment 4

[Aki Sasaki (not active)]

Attachment: [mozharness] add --b2g-config-dir to b2g_build.py

Comment 5

[Aki Sasaki (not active)]

Attachment: change --target panda-gaia-central to --target panda --b2g-config-dir panda-gaia-central

Comment 6

[Aki Sasaki (not active)]

I hid the panda-gaia-central builds on tbpl (m-c, m-i, m-a, m-b) til this is fixed.

Comment 7

[Aki Sasaki (not active)]

also m-b2g18.

Comment 8

[[e-mail] (:bhearsum)]

Comment on attachment 690610 [details] [diff] [review]
change --target panda-gaia-central to --target panda --b2g-config-dir panda-gaia-central

Review of attachment 690610 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/b2g_config.py
@@ +665,5 @@
>                  # b2g_build.py will checkout gecko from hg and look up a tooltool manifest given by the
>                  # --target name below
>                  # TODO: add gecko multilocale args
> +                'extra_args': ['--target', 'panda',
> +                               '--b2g-config-dir', 'panda-gaia-central',

I don't see --b2g-config-dir existing anywhere...at least according to mxr: https://mxr.mozilla.org/build-central/search?string=b2g-config-dir

Comment 9

[Ed Morley [:emorley]]

(In reply to Aki Sasaki [:aki] from comment #6)
> I hid the panda-gaia-central builds on tbpl (m-c, m-i, m-a, m-b) til this is
> fixed.

I've just added Try, fx-team, services-central, ionmonkey to that list

Comment 10

[Aki Sasaki (not active)]

(In reply to Ben Hearsum [:bhearsum] from comment #8)
> Comment on attachment 690610 [details] [diff] [review]
> change --target panda-gaia-central to --target panda --b2g-config-dir
> panda-gaia-central
> 
> Review of attachment 690610 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mozilla/b2g_config.py
> @@ +665,5 @@
> >                  # b2g_build.py will checkout gecko from hg and look up a tooltool manifest given by the
> >                  # --target name below
> >                  # TODO: add gecko multilocale args
> > +                'extra_args': ['--target', 'panda',
> > +                               '--b2g-config-dir', 'panda-gaia-central',
> 
> I don't see --b2g-config-dir existing anywhere...at least according to mxr:
> https://mxr.mozilla.org/build-central/search?string=b2g-config-dir

See the other patch on this bug.

Comment 11

[Aki Sasaki (not active)]

Comment on attachment 690609 [details] [diff] [review]
[mozharness] add --b2g-config-dir to b2g_build.py

http://hg.mozilla.org/build/mozharness/rev/5f483079897a

Comment 12

[Aki Sasaki (not active)]

Comment on attachment 690610 [details] [diff] [review]
change --target panda-gaia-central to --target panda --b2g-config-dir panda-gaia-central

http://hg.mozilla.org/build/buildbot-configs/rev/10328682a1a3

Comment 13

[Aki Sasaki (not active)]

This is in production.

Comment 14

[Aki Sasaki (not active)]

Green panda-gaia-central dep on b2g18.

Comment 15

[Aki Sasaki (not active)]

Unhidden on above branches.