820172 - Android build broken on NDK r8 due to missing std::nullptr_t in STLPort

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Bug 818941 fixed a typo in an ifdef check for std::nullptr_t. Unfortunately, we use STLport on Android and the NDK's version of STLport doesn't actually have std::nullptr_t

Comment 1

[Chris Peterson [:cpeterson]]

I think gcc needs to #include <cstddef> to get std::nullptr_t:

http://www.dune-project.org/flyspray/index.php?do=details&task_id=904

Comment 2

[(no longer active)]

(In reply to comment #1)
> I think gcc needs to #include <cstddef> to get std::nullptr_t:
> 
> http://www.dune-project.org/flyspray/index.php?do=details&task_id=904

Yeah somebody pointed this out on irc today too.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I ran into this today as well and fixed it locally using this patch:
https://hg.mozilla.org/try/rev/bb883f4d1f1e

Try run shows that it doesn't break existing builds using the older NDK either, but I don't know if it's a "correct" fix.
https://tbpl.mozilla.org/?tree=Try&rev=7c9410ad7e57

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Feel free to r- if there's a better fix for this.

Comment 5

[(no longer active)]

Comment on attachment 690709 [details] [diff] [review]
Patch

Review of attachment 690709 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, that works for me.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Thanks for the quick review :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3968901d047

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b3968901d047

Comment 8

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Patch for including B2G builds

We have the same problem with B2G builds using gcc-4.6 based toolchains.
When we are building B2G, no__ANDROID__symbol is defined, MOZ_B2G is, so I added it after the __ANDROID__ one.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Please file a new bug with a patch based off the latest trunk code. This bug has already been resolved and it will get confusing if you reuse it for the new patch.

Comment 10

[Juan Gomez [:_AtilA_] (CET/CEST)]

Ok, at the time I added the attachment, there was no resolution yet :P

Comment 11

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Juan Gomez [:_AtilA_] from comment #8)
> Created attachment 690904 [details] [diff] [review]
> Patch for including B2G builds
> 
> We have the same problem with B2G builds using gcc-4.6 based toolchains.
> When we are building B2G, no__ANDROID__symbol is defined, MOZ_B2G is, so I
> added it after the __ANDROID__ one.

In that case it might be better to check for _STLPORT_VERSION, instead of checking for __ANDROID__ and MOZ_B2G, since STLPort is why we don't have std::nullptr_t

Comment 12

[(no longer active)]

(In reply to comment #11)
> In that case it might be better to check for _STLPORT_VERSION, instead of
> checking for __ANDROID__ and MOZ_B2G, since STLPort is why we don't have
> std::nullptr_t

Agreed.