820177 - sound heard on bluetooth headset even when volume set to 0

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[Greg Grisco]

1. Switch ON BT from Settings>Bluetooth.
2. Pair to a Headset
3. Make a MT call, receive from headset
4. Set volume to 0 from headset

We can see that,even though the volume is 0, phone audio is still heard in the headset

Note:
-------
The same issue is seen even when volume is set to 0 from phone.

Comment 2

[Greg Grisco]

I'm not sure if this has anything to do with bluetooth. When I turn off BT and make MT call and set the volume to 0, I still hear in-call audio on phone speaker.

Comment 3

[Marco Chen [:mchen]]

Hi, could you try this same case with other commercial phone?
As I know that the volume 0 on in_call state doesn't really mute the remote audio, because what we want on in_call state is to hear the sound from remote.

Thanks.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

I believe the best way to resolve this bug is to remove the mute icon when on a call.
It's reasonable that voice is not mutable, you can only adjust it to a small value.

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Every other phone I'm aware of has voice mute.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

My Galaxy S3 cannot use the volume rocker to reach 0 when on a call. Seems like another solution to the UI.

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #5)
> Every other phone I'm aware of has voice mute.

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Misunderstood the bug. Android doesn't have voice mute features either. Ignore me. :)

Comment 8

[Andrew Overholt [:overholt]]

This seems like enough of an edge case that it shouldn't block.  If anyone disagrees, as usual, please re-nom with some reasoning.

Comment 9

[Michael Vines [:m1] [:evilmachines]]

Looks like the root complaint is merely that the volume should stop at 1 and not go to 0.  Purely a cosmetic app issue.    

It's not about the mute button as that doesn't affect the other party's volume.

Comment 12

[Cody Roesch [:croesch]]

Build ID: 20130130070201
Kernel: Dec 5
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4593f3e765eb
Gaia   f7f5a0cd17e3d04308cc5850b254947e127122b9


Testrun 4
Failed Testcase
https://moztrap.mozilla.org/runtests/run/712/env/296/?pagenumber=1&pagesize=100&sortfield=order&sortdirection=asc&filter-id=5809&filter-suite=208

UCID user-sound-028

When making a call, lowering the volume is misleading because it appears visually to be muted when it's not muted in actuality.

Comment 13

[pallavi]

when making a call, lowering the volume all the way down shows the mute icon but the sounds are still audible 
Unagi Build ID: 20130225070200
Environmental  Variables:
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a5a27992a75
Gaia: 5691a16fff8e1403c75ed9d6f3a443b7e58198c6
Notes:
Test Suite Name: User sound
UCID: User sound-028
Link to the failed test case: https://moztrap.mozilla.org/runtests/run/859/env/305/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=5809&filter-suite=208
Q Analysts Test Team Priority Rating:  Pri 3

Comment 14

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Sounds like the testcase might be invalid. Need requirements check.

Comment 15

[Michael Vines [:m1] [:evilmachines]]

Assuming the STR in comment 13 are accurate, tef+. We can't be displaying the mute icon while the other end can still hear.

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/8564

Patch proposal:
1. Hide mute button under telephony and bt_sco channel
2. Add one more segment to telephony and bt_sco channel

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

master https://github.com/mozilla-b2g/gaia/commit/ec06630af79ad556fca693c6a9375313a78323fa

Comment 18

[Andrew Overholt [:overholt]]

Should this be marked as FIXED?

Comment 19

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

I think comment 13 vs. comment 15 might be talking about two different things. 

Michael tef+'d based on mute not muting (i.e. microphone), but I think we're really talking about "silent mode" not being silent on bluetooth--that is, shows speaker off, but there's really slight sound coming through. Further, the testcase actually refers to the ringer volume not the call volume.

I don't think the microphone was involved here at all, and I'm pretty confused as to what functionality we think is fixed, tef+'d, etc.

Comment 20

[Lucas Adamski [:ladamski]]

Why is this really a blocker even if it is a bug?  Worst case the user can remove or turn off the headset.  Trivial user workaround.

Comment 21

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

I think it was marked blocker under the assumption the microphone showed muted when not muted. That would be a big privacy concern. But I don't think that's the bug.

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

Fixed but haven't be merged to v1-train or v1.0.1 yet.

The problem here is voice (and bt sco) really doesn't have mute state so I remove the mute icon and increase one more segment on UI -- to indicate voice volume doesn't go to 0 anyway.

But BT(a2dp) -- which isn't implemented in v1 -- should be muted normally.

It's up to drivers to determine if this is a blocker. I am marking fixed first.

Comment 23

[Michael Vines [:m1] [:evilmachines]]

(In reply to Geo Mealer [:geo] from comment #21)
> I think it was marked blocker under the assumption the microphone showed
> muted when not muted. That would be a big privacy concern. But I don't think
> that's the bug.

Yep, that's what I got out of it earlier.  But if this is not the case then yes I agree, not a blocker.

Comment 24

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Removing QA Wanted.  It's a valid test case:

1. Enter the dialer, enter a number and make a call.
V1 : you can hear the ringer sound while calling.

2. While the ringer is heard try to change the volume.
V2 : You are able to set the volume.

Comment 25

[Alex Keybl [:akeybl]]

Not a blocker, but Alive - can you nominate for uplift if this is low risk?

Comment 26

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alex Keybl [:akeybl] from comment #25)
> Not a blocker, but Alive - can you nominate for uplift if this is low risk?

Sure, lemme try to understand the nominate process now..

Comment 27

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 723354 [details]
https://github.com/mozilla-b2g/gaia/pull/8564

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:


Low risk because most of the fix is on CSS part.
(I cannot find approval-gaia-v1...)

Comment 28

[Leo]

Please uplift to V1-train, I set leo? gain

Comment 29

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 723354 [details]
https://github.com/mozilla-b2g/gaia/pull/8564

the approval-gaia-v1 flag is missing because of the product/component this is in - so approving for uplift to v1-train with the approval-mozilla-b2g18 flag.  

leo: This does not need to be leo+ to get uplifted, it's not a blocker, it's tracked, and we have a low risk fix to uplift.

Comment 30

[Ryan VanderMeulen [:RyanVM]]

John, can you assist with the uplift please? :)

Comment 31

[Ryan VanderMeulen [:RyanVM]]

James, maybe you can? :)

Comment 32

[James Lal [:lightsofapollo]]

in v1-train: c805382f646092ce133638e41bb265ee791bee7e
in v1.0.1: 9e7062731f6e06fda5c144c35459bf5fb3cfecd2