820185 - nsAutoJSValHolder's copy constructor needs to initialize its members

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Otherwise we crash when we use it. This isn't currently a problem with any existing code.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: patch

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 690615 [details] [diff] [review]
patch

https://hg.mozilla.org/integration/mozilla-inbound/rev/34f464e9a22c

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/34f464e9a22c

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 690615 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): A long time ago in a galaxy far, far away.

Bug 814026 requires this fix.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Just to be clear, this patch is completely risk-free. We were not initializing members correctly before.

Comment 6

[bhavana bajaj [:bajaj]]

Comment on attachment 690615 [details] [diff] [review]
patch

Approving on all the branches where bug 814026 is landing.

Comment 7

[Alex Keybl [:akeybl]]

Comment on attachment 690615 [details] [diff] [review]
patch

Because this is landing to mozilla-beta, it'll also land to mozilla-b2g18.

Please move forward with landing these fixes on all branches asap.

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b8be36705be3
https://hg.mozilla.org/releases/mozilla-beta/rev/790bcaaadd4d
https://hg.mozilla.org/releases/mozilla-esr17/rev/b81315ca0fd8
https://hg.mozilla.org/releases/mozilla-esr10/rev/8ebc550fa36e

That should be everything.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/790bcaaadd4d

Comment 10

[u279076]

Is there anything QA can do to shake out potential regression in the upcoming Firefox releases?

Comment 11

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #10)
> Is there anything QA can do to shake out potential regression in the
> upcoming Firefox releases?

For this patch in particular, there's nothing QA can really do. Testing and verifying bug 814026 will also verify this bug as well.

Comment 12

[u279076]

Thanks Blake. Marking this bug [qa-] based on comment 11.