820198 - Refactor webpay to use solitude transactions

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[Kumar McMillan [:kumar]]

Webpay has its own transaction table. I think we can replace it with Solitude transactions via API calls. This is related to refactoring in bug 817886. See bug 795140 to get a sense for how webpay needs to work with transactions.

Comment 1

[Andy McKay]

After chatting in irc with kumar, here's what I think we should do.

When the initial JWT comes in we:
* in webpay stuff the JWT and a transaction id into the session
* create a transaction in solitude that's in the pending state, it will have no amount yet. This gives us auditability of that transaction.

When any changes occur we then update that transaction in solitude as we need to. Webpay will be able to access the JWT and any data in there until the transaction is completed.

Comment 2

[Andy McKay]

Solitude changes: https://github.com/mozilla/solitude/commit/a58bed

Comment 3

[Kumar McMillan [:kumar]]

I had to add some stub code to work around the solitude transaction model. These changes should be undone when the refactoring lands:
https://github.com/mozilla/webpay/commit/e00de15fe8b85b2aab72bbf5bcb82b1d08aea198
https://github.com/mozilla/solitude/commit/8407aa6a5d1aa2710a9bd4bd39d9416f99b2933e

Comment 4

[Andy McKay]

https://github.com/mozilla/webpay/commit/278656 and reverted those commits. Lets see what breaks.