820216 - [bluetooth] Pairing screen shows incorrect character for apostrophe

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect, P3)

Description

[Marcia Knous [:marcia]]

Attachment: Screenshot of issue

Seen while running the daily smoketest using the 20121210 build

STR:
1. Set the language to Portuguese during the first run
2. Set the language back to English during the smoketest
3. Run the smoketest to pair the unagi device with another bluetooth device

Expected: I would receive a screen which shows the plural of Mozilla
Actual: I get the attached screenshot

Comment 1

[Brion Vibber]

Attachment: Similar screenshot with Apple keyboard

I encountered the same problem when trying to pair an Apple Bluetooth Keyboard; screenshot attached.

Looks like an encoding thing -- the curly quote mark ’ encodes to UTF-8 as \xe2\x80\x99 -- character U+00E2 is "â" and U+0080 and U+0099 are invisible control characters.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, P3, C3 - incorrect character for apostrophe doesn't make sense to user at all. 
Evelyn, can you take a quick look? could this be gecko issue?

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

Eric, can you take a look? Talked to Evelyn, it seems like Gaia is showing whatever that's passed to Gaia.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Attachment: patch 1: v1: should use JS_NewUCStringCopyN to copy a Unicode string

JS_NewUCStringCopyN should be used to create a JSString from an Unicode string(in this case, it's a nsString). Currently we are using JS_NewStringCopyN,  which is used to deal with C character arrays.

Please refer to the link below for more information.

* https://developer.mozilla.org/en-US/docs/SpiderMonkey/JSAPI_Reference/JS_NewStringCopyN

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 695734 [details] [diff] [review]
patch 1: v1: should use JS_NewUCStringCopyN to copy a Unicode string

Review of attachment 695734 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Thanks you for fixing this. :)

Comment 6

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a146aac182ef

Comment 7

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/mozilla-central/rev/a146aac182ef

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5fc70f785540
https://hg.mozilla.org/releases/mozilla-b2g18/rev/fb737de33cbb

Comment 9

[Walter Chen[:ypwalter][:wachen]]

Device: Unagi
Build Identifier: 20130113070202
Update channel: 
   nightly b2g18 (pvt server)  
   unagi.zip	13-Jan-2013 08:06 	100M	 
   https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi-eng/
Git commit info: 2013-11-13 15:15:51

Verified fixed