Closed Bug 820301 Opened 10 years ago Closed 10 years ago
Assert that ensure
Persistent Data Loaded is not called on Private Downloads Data
Internal minor enhancement, follow-up to bug 801232 comment 133, to make the meaning of the function clearer.
Is this what you mean by assert <http://mxr.mozilla.org/mozilla-central/source/toolkit/content/debug.js#32>?
NS_assert is bad cause it opens a dialog directly in the face of the user, and since it doesn't distinguish between us (devs) and the final user it can easily become an issue. Indeed we used it in Places for some time, but due to some hard to debug bugs they started appearing to the final users, and were quite harmful for UX. I think a simple Cu.reportError works fine for us.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #698111 - Flags: review?(mak77)
You should also remove the conditionals that check the object type later. I also expected an early return if the assertion failed, but I'll leave this style choice to Marco since we shouldn't reach that code path in any case.
(In reply to Paolo Amadini [:paolo] from comment #5) > I also expected an early return if the assertion failed, but I'll leave this > style choice to Marco since we shouldn't reach that code path in any case. I agree with early return
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
You need to log in before you can comment on or make changes to this bug.