820366 - INSUFFICIENT_STORAGE error is not triggered correctly *at restart*

Status: VERIFIED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Julien Wajsberg [:julienw]]

When restarting a download on a phone with low storage space, there is no error dialog.

STR:
* push a 2395140 kBytes (about 2.3 GB) file in /data
* "adb shell df /data" should report less than 8M free space (eg 6M)
* go to http://owapps.cloudfoundry.com with the browser
* install "big packaged app"
* accept the installation
* we get a dialog saying that there is not enough storage to install this app
* an icon is on the homescreen
* tap on the icon
* accept the download

Expected :
* we get a dialog saying that there is not enough storage to install this app

Actual :
* the download begins, the whole zip is downloaded
* there is a DOWNLOAD_ERROR because the zip can't be installed


logcat says :
I/Gecko   (  109): -*-*- Webapps.jsm : Free storage: 5083136. Download size: undefined

So it seems it doesn't find the download size correctly.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Attachment: v1

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/89ad76a08a74

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/89ad76a08a74

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4e00b7fbaa90
https://hg.mozilla.org/releases/mozilla-b2g18/rev/a2ef1dbbba07

Comment 5

[Jason Smith [:jsmith]]

Verified today doing some low space testing with appcache preloading for hosted apps and packaged apps.