82039 - Search option at the end of autocomplete popup doesnt work

Status: VERIFIED FIXED

(SeaMonkey :: Location Bar, defect)

Description

[Olivier Crête]

The search option at the end of the autocomplete popup seems to do the same
thing as hitting enter and not the same thing as hitting the search button.
Seems to be plugged into the wrong place, if that's intentional, then "Search
google" with a google logo doesnt seem appropriate.

Comment 1

[Olivier Crête]

Also, this bugs only happens when I start moz. If I go into the prefs and change
the search back to google, it will stay that way until I restart moz.

Comment 2

[Alec Flett]

ack, seeing this in 2001052204
reassign to hewitt, nominate for beta - pretty pointless if it just doesn't work!

Comment 3

[Todd Pringle]

Plussing and marking 0.9.1 to get on PDT radar.  This feature needs to work in
the beta.

Comment 4

[Joe Hewitt (gone)]

I have a really hard time reproducing this bug.  I have poked around in the code
and I think I have a patch that fixes it, but it's hard for me to be 100% sure
since I can't consistently observe the problem.  

Is there anybody out there who knows of a reliable sequence of events which
might cause this to happen?

Comment 5

[Joe Hewitt (gone)]

I figured out a way to reproduce this consistently.  You just have to change
your Internet Search preference to a new search engine, and voila, mousing over
the engine causes won't highlight it.

Here comes the magical patch.

Comment 6

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 7

[Blake Ross]

I like it. sr=blake. But I love you more.

Comment 8

[Alec Flett]

does this fix the actual problem where it doesn't perform the search?
That's my issue: I type "bugzilla" in the url bar, and then click the 'Search
Google for "bugzilla"' - but instead it goes to http://bugzilla/

Comment 9

[Olivier Crête]

That's also what I was thinking of when I filed this bug.

Comment 10

[Todd Pringle]

Joe, so this only happens when you switch engines in Internet Search
preferences?  If so, we can push this out to rtm.  Most users will not change
the default settings.

Comment 11

[Joe Hewitt (gone)]

Actually, there are other cases where it occurs, I just haven't been able to
reliably replicate those situations.  This patch is needed to ensure that the
search engine will work in all cases.

Comment 12

[Alec Flett]

No, this is key - my default installation did not work UNTIL I switched to a
non-default search engine...this is critical for beta, IMO...

Comment 13

[Todd Pringle]

Joe, so from your poking around, do you think this is something that a lot of
users will run in to when trying to use this feature?  If so, I agree we need to
get it in for beta.  What are the circumstances wherein you see this behavior
exactly?

Comment 14

[Joe Hewitt (gone)]

Alec - I'm not sure what you mean.  I just created a new profile, and the search
option worked ok for me.

Comment 15

[Joe Hewitt (gone)]

Alec, can you try the patch here to see if that fixes your problem?  I'm pretty
darn sure it will.  If so, reviewage would be appreciated.

Comment 16

[Alec Flett]

ok, I tried the patch.. and it made all cases work for me. r=alecf

there is very little risk in this, and I think that the added feedback
(highlighting the "Search Netscape for ...") makes a big difference in terms of
usability.. otherwise it looks like the feature is disabled or broken

Comment 17

[selmer (gone)]

Preemptive PDT approval from Steve.

Comment 18

[Christopher Blizzard (:blizzard)]

a=blizzard for 0.9.1

Comment 19

[Joe Hewitt (gone)]

fixed

Comment 20

[Claudius Gayle]

VERIFIED Fixed with 2001052908 build