Closed Bug 820497 Opened 10 years ago Closed 10 years ago

click-to-play: asynchronously adding different plugins won't update the popup notification


(Firefox :: General, defect)

Not set



Firefox 20
Tracking Status
firefox18 --- wontfix
firefox19 + verified
firefox20 + verified
firefox-esr17 19+ verified


(Reporter: keeler, Assigned: keeler)




(4 files, 1 obsolete file)

bug 754472 comment 41:
(In reply to Paul Silaghi [QA] from comment #41)
> Nightly 2012-12-10 Win 7 x64
> 1. Enable CTP
> 2. Open
> 3. Click the CTP doorhanger
> Actual results:
> Java is not on the list
> Any ideas? Works fine with other pages like

After a bit of investigation, it looks like if a plugin of a different type than those already present is added to the page after the others have been handled, the popup notification won't get updated to include the new type.
Attached patch patch (obsolete) — Splinter Review
This should do it. Unfortunately, it also means having a whole bunch of the same type of plugin objects on the same page will result in a lot of wasted work. I'm thinking a cached list of what types are already on the page could help? But maybe that's over-complicating things.
Attachment #691073 - Flags: review?(jaws)
Comment on attachment 691073 [details] [diff] [review]

Review of attachment 691073 [details] [diff] [review]:

::: browser/base/content/test/browser_bug820497.js
@@ +35,5 @@
> +    var notification = PopupNotifications.getNotification("click-to-play-plugins", gTestBrowser);
> +    ok(notification, "should have popup notification");
> +    is(notification.options.centerActions.length, 1, "should be 1 type of plugin in the popup notification");
> +  }
> +  else if (gNumPluginBindingsAttached == 2) {

} else if (...) {

@@ +49,5 @@
> +    gBrowser.removeCurrentTab();
> +    window.focus();
> +    finish();
> +  }
> +  else {

} else {
Attachment #691073 - Flags: review?(jaws) → review+
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Verified fixed on Nightly 2012-12-20 Win 7 x64, Ubuntu 12.04 and Mac OS X 10.8.2
Marking tracking-firefox19? as per bug 809846 comment 32 and 33.
Please prepare patches for Aurora/Beta/ESR17 so that we can land before the end of the week.
Attached patch patch for betaSplinter Review
[Approval Request Comment]
Bug caused by (feature/regressing bug #): click-to-play
User impact if declined: users won't be able to use the door-hanger to activate plugins added to the page dynamically
Testing completed (on m-c, etc.): landed in 20
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none
Attachment #706048 - Flags: review+
Attachment #706048 - Flags: approval-mozilla-beta?
Attached patch patch for esr17Splinter Review
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: needed for click-to-play
User impact if declined: see previous comment
Fix Landed on Version: 20
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

See for more info.
Attachment #706050 - Flags: review+
Attachment #706050 - Flags: approval-mozilla-esr17?
This is fixed in 20, so no need for an aurora patch. I'm carrying over r+ because the changes are not functional - just to make them apply cleanly to the different branches.
Comment on attachment 706048 [details] [diff] [review]
patch for beta

verified fixed, low risk, approving.
Attachment #706048 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #706050 - Flags: approval-mozilla-esr17? → approval-mozilla-esr17+
Shoot - I didn't mean to change the status-firefox20 flag. Sorry about that, Paul.
Verified fixed FF 19b4 Win7, Ubuntu 12.04, Mac OS X 10.7.5
Adding verifyme keyword as this will need verification in the next 17esr release.
Keywords: verifyme
(In reply to Anthony Hughes, Mozilla QA (:ashughes) from comment #17)
> Adding verifyme keyword as this will need verification in the next 17esr
> release.

Paul, if you don't want to wait for the release you can verify this with the latest 17esr nightly.
Verified fixed 2013-01-30-03-45-01-mozilla-esr17 Win7, Ubuntu 12.04, Mac OS X 10.8.2
Keywords: verifyme
Blocks: 1145179
You need to log in before you can comment on or make changes to this bug.