820516 - balrog admin ui shows bad json on the permissions page

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

14:27 <peterbe> btw, {'product': 'foo'} isn't valid JSON
14:27 <peterbe> http://www.hastebin.com/yemohoyago.py
14:27 <peterbe> You have to type it in as `{"product": "foo"}` but it's shown in the form as: http://cl.ly/LWXv
14:28 <bhearsum> oh yeah
14:28 <bhearsum> i always forget which quotes it is
14:28 <peterbe> well, it's still a bug that it's represented as {'product': 'foo'}
14:29 <bhearsum> yeah
14:29 <bhearsum> what's weird is that that output comes from simplejson IIRC
14:31 <peterbe> >>> simplejson.dumps({'product':'foo'})
14:31 <peterbe> '{"product": "foo"}'
14:32 <bhearsum> huh
14:32 <bhearsum> could be flask or wtforms mucking it up
14:32 <peterbe> to me it looks like it's doing repr({"product": 'foo'})
14:33 <peterbe> ...which is {'product': 'foo'}
14:33 <bhearsum> ah, that sounds likely

Comment 1

[Peter Bengtsson [:peterbe]]

PR https://github.com/mozilla/balrog/pull/10

:bhearsum r?

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/5cd88d9da50d53b5ba2552c0a770fdd91c58151a
bug 820516 - JSONField doesn't serialize JSON, r=bhearsum