Closed Bug 820544 Opened 7 years ago Closed 7 years ago

WebIDL dictionary with C++ keyword as member identifier will fail to compile.

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: wchen, Assigned: wchen)

References

Details

Attachments

(1 file, 1 obsolete file)

Stuff like this will fail to compile:

dictionary ElementRegistrationOptions {
  DocumentFragment? template = null;
};
Prefix dictionary members.
Attachment #691025 - Flags: review?(bzbarsky)
Comment on attachment 691025 [details] [diff] [review]
Prefix webidl dictionary native members names to avoid C++ keywords.

The big comment about "Use this->%s" is no longer relevant, since none of the locals will be named mFoo.  You can probably just use self.makeMemberName(member.identifier.name) for the declName now, and remove this comment altogether.  Similar for the "prop" in conversionReplacements, and for memberLoc and the comment before it.

Please update the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#Dictionary_types as well.

r=me with that.
Attachment #691025 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed
Blocks: 783129
https://hg.mozilla.org/mozilla-central/rev/bffe151ab8ac
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.