820544 - WebIDL dictionary with C++ keyword as member identifier will fail to compile.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[William Chen [:wchen]]

Stuff like this will fail to compile:

dictionary ElementRegistrationOptions {
  DocumentFragment? template = null;
};

Comment 1

[William Chen [:wchen]]

Attachment: Prefix webidl dictionary native members names to avoid C++ keywords.

Prefix dictionary members.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 691025 [details] [diff] [review]
Prefix webidl dictionary native members names to avoid C++ keywords.

The big comment about "Use this->%s" is no longer relevant, since none of the locals will be named mFoo.  You can probably just use self.makeMemberName(member.identifier.name) for the declName now, and remove this comment altogether.  Similar for the "prop" in conversionReplacements, and for memberLoc and the comment before it.

Please update the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/WebIDL_bindings#Dictionary_types as well.

r=me with that.

Comment 3

[William Chen [:wchen]]

Attachment: Prefix webidl dictionary native members names to avoid C++ keywords.

Comment 4

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67d84be0cc83

Comment 5

[Ed Morley [:emorley]]

Backed out for burning:
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=67d84be0cc83

https://hg.mozilla.org/integration/mozilla-inbound/rev/15e83fa70172

Comment 6

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bffe151ab8ac

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bffe151ab8ac