820545 - Safebrowsing-related text is not included in about:rights

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutRights.xhtml#46 says:

<!-- XXX Safe Browsing is not enabled in Firefox Mobile -->

which is not true any more. The hunk of text below it should probably be uncommented.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I don't think the about:rights page even has anything but placeholder text, so this patch doesn't seem to have any effect.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Oh, or maybe I can't see any change because I'm testing on a local unbranded build.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 691032 [details] [diff] [review]
Patch

Review of attachment 691032 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/aboutRights.xhtml
@@ +43,5 @@
>    <p>&rights2.webservices-a;<a href="about:rights#disabling-webservices" onclick="showDisablingServices();">&rights2.webservices-b;</a>&rights2.webservices-c;</p>
>  
>    <div id="disabling-webservices-container" style="margin-left:40px;">
>      <a name="disabling-webservices"/>
>      <!-- XXX Safe Browsing is not enabled in Firefox Mobile -->

Lose the comment, too.

r+ on the assumption that you do a test build with branding enabled :)

Comment 5

[Gian-Carlo Pascutto [:gcp]]

We enabled SafeBrowsing on Firefox 18 so this is a candidate for uplifting. Especially as impact should be minimal.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Note: No strings are added, so we should be OK for uplift.

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 691032 [details] [diff] [review]
Patch

As per discussion on IRC, this will need a different patch or a WONTFIX. The instructions explain how to disable SafeBrowsing, which is not possible or needs about:config on mobile.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Update comment to not fool people

Comment 9

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1868793fca42

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1868793fca42