Closed Bug 820545 Opened 7 years ago Closed 7 years ago

Safebrowsing-related text is not included in about:rights

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file, 1 obsolete file)

http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/aboutRights.xhtml#46 says:

<!-- XXX Safe Browsing is not enabled in Firefox Mobile -->

which is not true any more. The hunk of text below it should probably be uncommented.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → bugmail.mozilla
Attachment #691032 - Flags: review?(gpascutto)
I don't think the about:rights page even has anything but placeholder text, so this patch doesn't seem to have any effect.
Oh, or maybe I can't see any change because I'm testing on a local unbranded build.
Comment on attachment 691032 [details] [diff] [review]
Patch

Review of attachment 691032 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/aboutRights.xhtml
@@ +43,5 @@
>    <p>&rights2.webservices-a;<a href="about:rights#disabling-webservices" onclick="showDisablingServices();">&rights2.webservices-b;</a>&rights2.webservices-c;</p>
>  
>    <div id="disabling-webservices-container" style="margin-left:40px;">
>      <a name="disabling-webservices"/>
>      <!-- XXX Safe Browsing is not enabled in Firefox Mobile -->

Lose the comment, too.

r+ on the assumption that you do a test build with branding enabled :)
Attachment #691032 - Flags: review?(gpascutto) → review+
We enabled SafeBrowsing on Firefox 18 so this is a candidate for uplifting. Especially as impact should be minimal.
Note: No strings are added, so we should be OK for uplift.
Comment on attachment 691032 [details] [diff] [review]
Patch

As per discussion on IRC, this will need a different patch or a WONTFIX. The instructions explain how to disable SafeBrowsing, which is not possible or needs about:config on mobile.
Attachment #691032 - Flags: review+ → review-
Attached patch PatchSplinter Review
Update comment to not fool people
Attachment #691464 - Flags: review?(gpascutto)
Attachment #691464 - Flags: review?(gpascutto) → review+
https://hg.mozilla.org/mozilla-central/rev/1868793fca42
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.