820546 - Files are preprocessed unnecessary when building fennec's chrome jar

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The jar manifest at http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/jar.mn specifies that some files be preprocessed (the ones with a '*' in the first column). However some of those files don't need to be preprocessed. Specifically, downloads.js and browser.xul do not appear to be modified during preprocessing.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

A couple of other files also don't need preprocessing if they use XML comments instead of # comments. Will request review once this is done building for me and I can test it.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Whoops, attached the wrong patch in the last comment. Here is the right one, and it does seem to work fine

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 691076 [details] [diff] [review]
Patch

In the old days, we used preprocessor comments, rather than HTML comments, because the resulting code file was smaller and had less to parse. I'm not sure that ever helped too much, and probably makes no difference now.

So, sure... let's do this.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a18d27e6d78a

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a18d27e6d78a