Closed Bug 820546 Opened 8 years ago Closed 8 years ago

Files are preprocessed unnecessary when building fennec's chrome jar

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: kats, Assigned: kats)

Details

Attachments

(1 file, 1 obsolete file)

The jar manifest at http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/jar.mn specifies that some files be preprocessed (the ones with a '*' in the first column). However some of those files don't need to be preprocessed. Specifically, downloads.js and browser.xul do not appear to be modified during preprocessing.
Attached patch Patch (obsolete) — Splinter Review
A couple of other files also don't need preprocessing if they use XML comments instead of # comments. Will request review once this is done building for me and I can test it.
Assignee: nobody → bugmail.mozilla
Attached patch PatchSplinter Review
Whoops, attached the wrong patch in the last comment. Here is the right one, and it does seem to work fine
Attachment #691033 - Attachment is obsolete: true
Attachment #691076 - Flags: review?(mark.finkle)
Comment on attachment 691076 [details] [diff] [review]
Patch

In the old days, we used preprocessor comments, rather than HTML comments, because the resulting code file was smaller and had less to parse. I'm not sure that ever helped too much, and probably makes no difference now.

So, sure... let's do this.
Attachment #691076 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/a18d27e6d78a
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.