820556 - gfx code in Fennec has some cruft

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

cruft should die with fire.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: cruft the first

mUsesDefaultProgram is always true

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 691049 [details] [diff] [review]
cruft the first

Good catch, thanks

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: cruft the second

this code hasn't been needed since bug 727352

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: cruft the third

unused since bug 814437

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a41a29550c44
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fd28dc82cc0
https://hg.mozilla.org/integration/mozilla-inbound/rev/99a78630d2c2

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a41a29550c44
https://hg.mozilla.org/mozilla-central/rev/2fd28dc82cc0
https://hg.mozilla.org/mozilla-central/rev/99a78630d2c2

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 691051 [details] [diff] [review]
cruft the second

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 727352 is the one that made this code turn into cruft
User impact if declined: harder to rebase and uplift bug 817134. That's the only reason I want to uplift this.
Testing completed (on m-c, etc.): on m-c and nightlies (FF20), try run with it pushed on FF19 as well.
Risk to taking this patch (and alternatives if risky): low-risk; the code is dead and the patch isn't that large. android only.
String or UUID changes made by this patch: none

Comment 8

[Alex Keybl [:akeybl]]

Comment on attachment 691051 [details] [diff] [review]
cruft the second

Approving to limit risk to uplifting bug 817134, which is being uplifted in support of fixing top crasher bug 817514. Added bonus of keeping our repos in sync for future changes.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Landed attachment 691051 [details] [diff] [review] on mozilla-beta:

https://hg.mozilla.org/releases/mozilla-beta/rev/45339f2e0368