Closed Bug 820561 Opened 7 years ago Closed 7 years ago

Unnecessary painting while scrolling

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-basecamp:-, firefox19 fixed, firefox20 fixed, b2g18 fixed)

RESOLVED FIXED
B2G C3 (12dec-1jan)
blocking-basecamp -
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: ajones, Assigned: ajones)

Details

(Keywords: b2g-testdriver, unagi)

Attachments

(1 file)

1. Enable paint flashing
2. Navigate to http://www.nytimes.com/
3. Zoom in and scroll around

Full screen repaints are occurring more often than necessary
Attachment #691047 - Attachment description: Bug 820561 - Reduce unnecessary full screen painting; r=roc → Reduce unnecessary full screen painting
Attachment #691047 - Flags: review?(roc)
Component: Gaia → General
We discussed this during triage and it doesn't feel like something we'd hold the release for.  If you disagree, please re-nom.
blocking-basecamp: ? → -
Comment on attachment 691047 [details] [diff] [review]
Reduce unnecessary full screen painting

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
 dlbi, sort of
User impact if declined:
 poor repainting performance in the b2g browser, which is a current partner complaint.
Testing completed:
 manual, but this is a semantics-preserving patch
Risk to taking this patch (and alternatives if risky):
 none to desktop.  Fennec is affected.  Risk is low.  Performance improvements should be shared with fennec, but risk is shared too.
String or UUID changes made by this patch:
 none
Attachment #691047 - Flags: approval-mozilla-b2g18?
Attachment #691047 - Flags: approval-mozilla-aurora?
Assignee: nobody → ajones
Oh, this hasn't landed yet :).

I was about to say, it would be interesting to see eideticker results from before/after this patch.
Try run for ff3b923cfe10 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=ff3b923cfe10
Results (out of 100 total builds):
    exception: 1
    success: 84
    warnings: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-ff3b923cfe10
Anything blocking landing this?  The try run looks good.
(In reply to Chris Jones [:cjones] [:warhammer] from comment #4)
> Oh, this hasn't landed yet :).
> 
> I was about to say, it would be interesting to see eideticker results from
> before/after this patch.

If I understand this bug correctly, you should see fennec results for this on the standard eideticker dashboard after it's committed (and hits the nightlies):

http://eideticker.wrla.ch
Attachment #691047 - Flags: approval-mozilla-b2g18?
Attachment #691047 - Flags: approval-mozilla-b2g18+
Attachment #691047 - Flags: approval-mozilla-aurora?
Attachment #691047 - Flags: approval-mozilla-aurora+
Try run for 31aba3c1f846 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=31aba3c1f846
Results (out of 28 total builds):
    exception: 1
    success: 24
    warnings: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-31aba3c1f846
https://hg.mozilla.org/mozilla-central/rev/abfeb0733ddd
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Try run for ff3b923cfe10 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=ff3b923cfe10
Results (out of 102 total builds):
    exception: 2
    success: 84
    warnings: 16
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/ajones@mozilla.com-ff3b923cfe10
You need to log in before you can comment on or make changes to this bug.