820561 - Unnecessary painting while scrolling

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

1. Enable paint flashing
2. Navigate to http://www.nytimes.com/
3. Zoom in and scroll around

Full screen repaints are occurring more often than necessary

Comment 1

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Attachment: Reduce unnecessary full screen painting

Comment 2

[Andrew Overholt [:overholt]]

We discussed this during triage and it doesn't feel like something we'd hold the release for.  If you disagree, please re-nom.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 691047 [details] [diff] [review]
Reduce unnecessary full screen painting

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
 dlbi, sort of
User impact if declined:
 poor repainting performance in the b2g browser, which is a current partner complaint.
Testing completed:
 manual, but this is a semantics-preserving patch
Risk to taking this patch (and alternatives if risky):
 none to desktop.  Fennec is affected.  Risk is low.  Performance improvements should be shared with fennec, but risk is shared too.
String or UUID changes made by this patch:
 none

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Oh, this hasn't landed yet :).

I was about to say, it would be interesting to see eideticker results from before/after this patch.

Comment 5

[Mozilla RelEng Bot]

Try run for ff3b923cfe10 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=ff3b923cfe10
Results (out of 100 total builds):
    exception: 1
    success: 84
    warnings: 15
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-ff3b923cfe10

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Anything blocking landing this?  The try run looks good.

Comment 7

[William Lachance (:wlach)]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #4)
> Oh, this hasn't landed yet :).
> 
> I was about to say, it would be interesting to see eideticker results from
> before/after this patch.

If I understand this bug correctly, you should see fennec results for this on the standard eideticker dashboard after it's committed (and hits the nightlies):

http://eideticker.wrla.ch

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/abfeb0733ddd

Comment 9

[Mozilla RelEng Bot]

Try run for 31aba3c1f846 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=31aba3c1f846
Results (out of 28 total builds):
    exception: 1
    success: 24
    warnings: 3
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-31aba3c1f846

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/abfeb0733ddd

Comment 11

[Kartikaya Gupta (email:[e-mail])]

\o/

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bde2bb5f6cb2
https://hg.mozilla.org/releases/mozilla-b2g18/rev/136b44d441b3

Comment 13

[Mozilla RelEng Bot]

Try run for ff3b923cfe10 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=ff3b923cfe10
Results (out of 102 total builds):
    exception: 2
    success: 84
    warnings: 16
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-ff3b923cfe10