820623 - Javascript warning on fennec startup (NativeWindow.menu.add)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

12-11 18:51:43.166 E/GeckoConsole(14235): [JavaScript Warning: "TypeError: anonymous function does not always return a value" {file: "chrome://browser/content/browser.js" line: 1208 column: 6 source: "      return this._menuId - 1;

NativeWindow.menu.add has two return statements; one of which returns a value and the other does not.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Instead of returning nothing, we should throw an exception.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Replace the "return" with a "throw"

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 691189 [details] [diff] [review]
patch

Review of attachment 691189 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the typo fixed

::: mobile/android/chrome/content/browser.js
@@ +1199,5 @@
>              icon: arguments[1],
>              callback: arguments[2]
>            };
>        } else {
> +         Throw "Incorrect number of parameters";

Lowercase the 't' in throw. I believe it's case-sensitive.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b3ec53cab89

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1b3ec53cab89