820634 - Selected ringtone not being honored

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Marcia Knous [:marcia]]

Seen while running unagi using

Gaia: bf21e0c83930
Gecko: f1c0c74ea9f5

STR:
1. Set a ringtone in settings
2. Call you phone

Expected: I would hear the selected ring tone
Actual: It defaults back to classic prism

Comment 1

[Dietrich Ayala (:dietrich)]

P1+C3 because smoketest blocker.

Comment 2

[Dylan Oliver [:doliver]]

Kevin, can you take a look?

Comment 3

[Kevin Grandon :kgrandon]

More than happy to take a look at this. Right now I'm still waiting to get my SIM card in the mail though. I'll see if I can test this with one of my existing SIM cards though.

Comment 4

[Dylan Oliver [:doliver]]

Marcia, are you still seeing this? Works for me in the 12/13 nightly.

Comment 5

[Marcia Knous [:marcia]]

Dylan: This is working for me using today's build. Resolving as WFM.

(In reply to Dylan Oliver [:doliver] from comment #4)
> Marcia, are you still seeing this? Works for me in the 12/13 nightly.

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I'm seeing issues with the ring tones in today's build 12/21

Comment 7

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

This occurs when I select Wind chimes.  There might be some other ones.  Certain ones do seem to sound.

Comment 8

[Kevin Grandon :kgrandon]

Looks like every ringtone except the wind chimes works for me. It appears that there is a filename mismatch currently. I'm testing it out now, but the fix should be pretty simple. Would nominate that we block for this. 

This new issue is different than the originally reported issue, but still related to ringtones.

Comment 9

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Comment 10

[Dylan Oliver [:doliver]]

I don't think we'd block on this one but would definitely take the fix after review.

On today's build I'm not able to exit the ringtone select screen if I choose wind chimes, so if that's the behavior it does suck but you aren't going to end up in a situation where your phone doesn't ring.

Comment 11

[Dylan Oliver [:doliver]]

Removing smoketest -- this bug has morphed into something less serious since that tag was applied.

Comment 12

[David Scravaglieri [:scravag]]

WORKSFORME with changeset

gecko-b2g18: b27b0eadf48c
gaia: 2d8eee9753ad7d3ee1c74ec99e2b6629c35e3f99

Please renominate if needed

Comment 13

[Kevin Grandon :kgrandon]

Hi David,

I'm still seeing the broken ringtone with fresh builds of B2G/gaia on master branch. Did you specifically test the "Wind Chimes"  ringtone?

I'd really like to see this one land if possible - the fix is extremely simple (one character), and has no possible regressions. It just feels very wrong to ship with a broken feature, and is extremely jarring if I'm going down the list listening to all ringtones and one does not work.

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

Triage: comment 13 seem to be different from what this bug is originally reporting. Should be a different issue.

Comment 16

[Joe Cheng [:jcheng] (please needinfo)]

Triage: BB+, P3, C3 - confuses the user on whether their ringtone is set or not. even if they check the UI, it seems like the ringtone is correctly chosen but actually not.

Comment 17

[Kevin Grandon :kgrandon]

Comment on attachment 694988 [details]
Github pull request pointer

Just looking for a quick review for this one character change, thanks!

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 694988 [details]
Github pull request pointer

Kevin is fixing one of the issue, this can be a good part 1 patch.

The underling issue is about the behavior of [OK] on the top right and the [Back] on the top left of the selection dialog.

- If the user hits back, we should revert the selection when the user goes into the panel dialog again since the selection is not saved into the database
- Only if the user hits OK we should update the database and the selection when the user enter the panel next time.

It's really not hard, but the current Settings app dialog behavior is really messy....

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/7187

Patch v1:
1. Reset ringtone preview when leaving sound selection panel
2. Reactivate ringtone selection when entering sound selection panel
3. Uh, there's no stop() function in audio element....fix it.

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 695702 [details]
https://github.com/mozilla-b2g/gaia/pull/7187

r=me, I trust your manual tests!

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/6e6d3e619bc4a67e5ce4b6f81c2a3d4eb3bece32
Marry Xmas <O/

Comment 22

[Angela Hubenya]

Defect is verified as fixed using Unagi, build 20130103070201