820665 - Update WebIDL bindings to spec changes in what objects can be used as dictionaries/callbacks/callback-interfaces

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Specifically, we have the following changes:

1) All non-Date and non-RegExp objects can be used as dictionaries.
2) All callables can be used as callback functions (that's what we did already,
   mostly).
3) Callback interfaces can be implemented by all non-platform objects, except for
   non-single-operation interfaces the object must also not be a Date or a RegExp.
4) Overload resolution and union conversions have similar restrictions (though the
   spec is not quite there yet; I sent some mail to Cameron).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. More WebIDL spec updates to changes in how dictionaries work. the following changes:

1) A union that includes a dictionary and is the last non-optional
   argument must actually be marked optional, just like a dictionary
   argument.
2) Disallow a union from containing both a nullable type and a dictionary.
3) Now all non-Date and non-RegExp objects can be used as dictionaries,
   including from overload resolution and union conversion.

We don't support dictionaries inside unions yet, or unions as
distinguishing args, so the spec changes to do with converting null to
dictionaries inside a union or picking the union overload if there is
a union containing a dictionary and null is the distinguishing arg
value are not relevant to us so far.

Comment 2

[Boris Zbarsky [:bzbarsky]]

There have been more changes since comment 0, especially for callback interfaces.  Patches still coming up.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Part 1, but with unions fixed to not be totally broken

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. WebIDL spec updates to changes in how callback functions work. all callables can be converted to a callback, including

in overload resolution and union conversions.  We already did this for
normal callback arguments, but not the overload/union case.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. WebIDL spec updates to changes in how callback interfaces work. any object that's not a Date or RegExp can implement a callback interface.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove no-longer-used IsPlatformObject.

Comment 7

[Boris Zbarsky [:bzbarsky]]

  https://hg.mozilla.org/integration/mozilla-inbound/rev/cc603feaa286
  https://hg.mozilla.org/integration/mozilla-inbound/rev/e78f9e6ea4d9
  https://hg.mozilla.org/integration/mozilla-inbound/rev/ed9af04edd8c
  https://hg.mozilla.org/integration/mozilla-inbound/rev/e72009158e15

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cc603feaa286
https://hg.mozilla.org/mozilla-central/rev/e78f9e6ea4d9
https://hg.mozilla.org/mozilla-central/rev/ed9af04edd8c
https://hg.mozilla.org/mozilla-central/rev/e72009158e15