Closed
Bug 820665
Opened 11 years ago
Closed 11 years ago
Update WebIDL bindings to spec changes in what objects can be used as dictionaries/callbacks/callback-interfaces
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(4 files, 1 obsolete file)
30.45 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
5.85 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
11.46 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
1.53 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Specifically, we have the following changes: 1) All non-Date and non-RegExp objects can be used as dictionaries. 2) All callables can be used as callback functions (that's what we did already, mostly). 3) Callback interfaces can be implemented by all non-platform objects, except for non-single-operation interfaces the object must also not be a Date or a RegExp. 4) Overload resolution and union conversions have similar restrictions (though the spec is not quite there yet; I sent some mail to Cameron).
Assignee | ||
Comment 1•11 years ago
|
||
1) A union that includes a dictionary and is the last non-optional argument must actually be marked optional, just like a dictionary argument. 2) Disallow a union from containing both a nullable type and a dictionary. 3) Now all non-Date and non-RegExp objects can be used as dictionaries, including from overload resolution and union conversion. We don't support dictionaries inside unions yet, or unions as distinguishing args, so the spec changes to do with converting null to dictionaries inside a union or picking the union overload if there is a union containing a dictionary and null is the distinguishing arg value are not relevant to us so far.
Attachment #692169 -
Flags: review?(khuey)
Assignee | ||
Comment 2•11 years ago
|
||
There have been more changes since comment 0, especially for callback interfaces. Patches still coming up.
Assignee | ||
Comment 3•11 years ago
|
||
Attachment #692176 -
Flags: review?(khuey)
Assignee | ||
Updated•11 years ago
|
Attachment #692169 -
Attachment is obsolete: true
Attachment #692169 -
Flags: review?(khuey)
Assignee | ||
Comment 4•11 years ago
|
||
in overload resolution and union conversions. We already did this for normal callback arguments, but not the overload/union case.
Attachment #692177 -
Flags: review?(khuey)
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #692185 -
Flags: review?(khuey)
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #692332 -
Flags: review?(khuey)
Assignee | ||
Updated•11 years ago
|
Whiteboard: [need review]
Attachment #692177 -
Flags: review?(khuey) → review+
Attachment #692176 -
Flags: review?(khuey) → review+
Attachment #692185 -
Flags: review?(khuey) → review+
Attachment #692332 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 7•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc603feaa286 https://hg.mozilla.org/integration/mozilla-inbound/rev/e78f9e6ea4d9 https://hg.mozilla.org/integration/mozilla-inbound/rev/ed9af04edd8c https://hg.mozilla.org/integration/mozilla-inbound/rev/e72009158e15
Flags: in-testsuite?
Target Milestone: --- → mozilla20
Assignee | ||
Updated•11 years ago
|
Whiteboard: [need review]
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cc603feaa286 https://hg.mozilla.org/mozilla-central/rev/e78f9e6ea4d9 https://hg.mozilla.org/mozilla-central/rev/ed9af04edd8c https://hg.mozilla.org/mozilla-central/rev/e72009158e15
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•