Closed
Bug 820671
Opened 13 years ago
Closed 13 years ago
Make PCImpl a tombstone if mMedia is null
Categories
(Core :: WebRTC: Signaling, defect, P1)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: ekr, Assigned: ekr)
References
Details
(Whiteboard: [WebRTC], [blocking-webrtc+] [qa-])
Attachments
(1 file)
|
1.14 KB,
patch
|
jesup
:
review+
ehugg
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Updated•13 years ago
|
Attachment #691195 -
Flags: review?(rjesup)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 691195 [details] [diff] [review]
Make PCImpl a tombstone if mMedia is null
Review of attachment 691195 [details] [diff] [review]:
-----------------------------------------------------------------
I assume all the users of PeerConnectionWrappers check for null, right?
Attachment #691195 -
Flags: review?(rjesup) → review+
|
|
||
Updated•13 years ago
|
Priority: -- → P1
Whiteboard: [WebRTC], [blocking-webrtc+]
|
|
Assignee | |
Comment 3•13 years ago
|
||
That's the API requirement.(In reply to Randell Jesup [:jesup] from comment #2)
> Comment on attachment 691195 [details] [diff] [review]
> Make PCImpl a tombstone if mMedia is null
>
> Review of attachment 691195 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> I assume all the users of PeerConnectionWrappers check for null, right?
That's the API requirement. Anyone that doesn't is already broken.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Comment on attachment 691195 [details] [diff] [review]
Make PCImpl a tombstone if mMedia is null
Review of attachment 691195 [details] [diff] [review]:
-----------------------------------------------------------------
Ethan
Could you please land this? I'm at the end of a slow supply line.
Attachment #691195 -
Flags: checkin?(ethanhugg)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 691195 [details] [diff] [review]
Make PCImpl a tombstone if mMedia is null
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd712828cb47
Attachment #691195 -
Flags: checkin?(ethanhugg) → checkin+
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•13 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc+] → [WebRTC], [blocking-webrtc+] [qa-]
|
|
||
Updated•12 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•