Closed Bug 820681 Opened 7 years ago Closed 7 years ago

OS.Constants.Path.profileDir should be undefined when its value is not known

Categories

(Toolkit :: OS.File, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: Yoric, Assigned: Yoric)

References

Details

Attachments

(2 files, 1 obsolete file)

As bug 810543 was, ahem, landed before I had marked it checkin-needed, moving here the final fixes initially intended for that bug.
Assignee: nobody → dteller
Attachment #691294 - Flags: review+
Attached patch 1. OS.Constants.Path fix (obsolete) — Splinter Review
Attachment #691295 - Flags: review?(khuey)
Comment on attachment 691295 [details] [diff] [review]
1. OS.Constants.Path fix

Rather than rely on calling GetPathToSpecialDir on each string and that calling SetIsVoid on the strings, I think you should just add a ctor to Path that calls SetIsVoid on all its strings.
Attachment #691295 - Flags: review?(khuey) → review-
Good point. Attaching a new version that rather initializes all fields of Paths to void strings.
Attachment #691295 - Attachment is obsolete: true
Attachment #692657 - Flags: review?(khuey)
Comment on attachment 692657 [details] [diff] [review]
1. OS.Constants.Path fix, v2

Review of attachment 692657 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #692657 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/a0f9ff3c9894
https://hg.mozilla.org/mozilla-central/rev/9736bd231bdc
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Depends on: 879133
No longer depends on: 879133
You need to log in before you can comment on or make changes to this bug.