820681 - OS.Constants.Path.profileDir should be undefined when its value is not known

Status: RESOLVED FIXED

(Toolkit Graveyard :: OS.File, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

As bug 810543 was, ahem, landed before I had marked it checkin-needed, moving here the final fixes initially intended for that bug.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: 2. The test, restored to its previous semantics

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: 1. OS.Constants.Path fix

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 691295 [details] [diff] [review]
1. OS.Constants.Path fix

Rather than rely on calling GetPathToSpecialDir on each string and that calling SetIsVoid on the strings, I think you should just add a ctor to Path that calls SetIsVoid on all its strings.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: 1. OS.Constants.Path fix, v2

Good point. Attaching a new version that rather initializes all fields of Paths to void strings.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 692657 [details] [diff] [review]
1. OS.Constants.Path fix, v2

Review of attachment 692657 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 6

[David Teller [:Yoric] - still alive but not very active]

Try: https://tbpl.mozilla.org/?tree=Try&rev=99a5fc1fbe53

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0f9ff3c9894
https://hg.mozilla.org/integration/mozilla-inbound/rev/9736bd231bdc

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a0f9ff3c9894
https://hg.mozilla.org/mozilla-central/rev/9736bd231bdc