820692 - JS GDB pretty-printers: ptr-to-JSOBject pretty-printer fails with latest GDB sources

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jim Blandy :jimb]

When run against a GDB built from the current sources (as of this bug's posting), the pointer-to-JSObject pretty-printer fails trying to find the value of the DELEGATE bit:

Traceback (most recent call last):
  File "/home/jimb/moz/dbg/js/src/gdb/mozilla/prettyprinters.py", line 235, in lookup
    p = check_table(ptr_printers_by_tag, t2.tag)
  File "/home/jimb/moz/dbg/js/src/gdb/mozilla/prettyprinters.py", line 226, in check_table
    return f(value, cache)
  File "/home/jimb/moz/dbg/js/src/gdb/mozilla/JSObject.py", line 26, in __init__
    cache.mod_JSObject = JSObjectTypeCache(value, cache)
  File "/home/jimb/moz/dbg/js/src/gdb/mozilla/JSObject.py", line 14, in __init__
    self.flag_DELEGATE = baseshape_flags['js::BaseShape::DELEGATE'].bitpos
AttributeError: 'gdb.Field' object has no attribute 'bitpos'

Comment 1

[Jim Blandy :jimb]

It seems like recent GDBs actually give gdb.Field instances separate 'bitpos' and 'enumval' properties, depending on whether the field represents a structure member or an enum value. This appears to have been part of a change to make GDB not store enum values internally in the 'bitpos' member of 'struct field' objects (dfd32e4e, 2012-4-18).

Comment 2

[Jim Blandy :jimb]

Attachment: JS GDB pretty-printers: find enum values correctly, whether GDB stores them as .bitpos or .enumval.

This patch also includes a fix for a minor error-printing bug in run-tests.py.

Comment 3

[Jim Blandy :jimb]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f4beffe262c5

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f4beffe262c5