820708 - "Unknown" plugin in CTP plugins list after disabling/enabling plugins

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Paul Silaghi, QA [:pauly]]

STR:
1. Open addons manager and disable flash
2. Restart Firefox
3. Open http://mozqa.com/data/firefox/plugins/plugin-test.html --> see the missing plugin notification instead of flash
4. Open addons manager and enable flash
5. Reload the tab from step 3

Actual results:
"unknown plugin" instead of flash

Works fine after restarting FF.

Comment 1

[Paul Silaghi, QA [:pauly]]

This came once with the new CTP UI - bug 754472.

Comment 2

[Dana Keeler (she/her) [:keeler]]

Attachment: patch

Looks like when enabling/disabling plugins, navigator.plugins doesn't get updated. This makes nsPluginHost notify observers of a "plugin-info-updated" event. Navigator observes this and refreshes its plugins. Josh - how does this look?

Comment 3

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 694625 [details] [diff] [review]
patch

Review of attachment 694625 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Navigator.cpp
@@ -100,5 @@
>  Navigator::Navigator(nsPIDOMWindow* aWindow)
>    : mWindow(do_GetWeakReference(aWindow))
>  {
>    NS_ASSERTION(aWindow->IsInnerWindow(),
> -               "Navigator must get an inner window!");

I don't know how this happened, but I'll fix it before checking in (if this gets r+) or posting a new version (if this doesn't get r+).

Comment 4

[Dana Keeler (she/her) [:keeler]]

Attachment: patch

I fixed the above issue, renamed a variable, and added a comment explaining a bit more what was going on. Carrying over r+.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=ce21dbddfa29

Comment 5

[Dana Keeler (she/her) [:keeler]]

Attachment: patch v1.1

Looks like I needed to add another #include for b2g. Carrying over r+.
This one looks good: https://tbpl.mozilla.org/?tree=Try&rev=3ef465b30ebd
Checkin: https://hg.mozilla.org/integration/mozilla-inbound/rev/c90851414292

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c90851414292

Comment 7

[Paul Silaghi, QA [:pauly]]

Verified fixed Nightly 21.0a1 (2013-01-09) Win 7 x64.