Closed
Bug 820724
Opened 13 years ago
Closed 13 years ago
Add support for more elaborate expressions for Preprocessor.py
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
|
6.71 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
I seem to remember there are some places where we're going through hoops around the lack of &&, || and defined() in Preprocessor.py. I happen to be hitting one more in bug 755724 so enough is enough.
|
Assignee | |
Comment 1•13 years ago
|
||
This allows #if defined(FOO) || defined(BAR) && defined(BAZ)
Attachment #691246 -
Flags: review?(ted)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 691246 [details] [diff] [review]
Add support for more elaborate expressions for Preprocessor.py
Review of attachment 691246 [details] [diff] [review]:
-----------------------------------------------------------------
I predict that we're going to want parentheses next. Thanks for fixing this.
::: config/Expression.py
@@ +58,5 @@
> + return rv
> +
> + def __get_logical_and(self):
> + """
> + Production: test ( '||' and_cond ) ?
&&
|
|
||
Updated•13 years ago
|
Attachment #691246 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•