820728 - Smart Folders 'more' screen adding duplicates

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Evyatar 'Tron' Amitay (everything.me)]

Due to a change in the behavior of the 'change' event of the SELECT element, when selecting multiple elements and then closing the select it fires multiple change events- one per selected item.

This causes duplicate items to be added to Ev.me.

Comment 1

[Evyatar 'Tron' Amitay (everything.me)]

Attachment: Patch - redirect to github PR

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 691251 [details]
Patch - redirect to github PR

ok, minor changes

Comment 3

[Evyatar 'Tron' Amitay (everything.me)]

Comment on attachment 691251 [details]
Patch - redirect to github PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 691251 [details]
Patch - redirect to github PR

Sorry for not having seen it. I would have if the patch was in the bb+ bug. As a result I believe this has already been resolved.

Can you close the bug if that's fine for you?

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

Probably has due to this change https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/modules/ShortcutsCustomize/ShortcutsCustomize.js#L11
But the PR code is a bit more defensive and organised.

Can you consider approving it?

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/b38a5ae022d350915e40aa9dd880bccd291d364f