820763 - Stop using addvisit() in toolkit tests

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

The following tests are still using addVisit:

toolkit/components/places/tests/browser/browser_bug248970.js
toolkit/components/downloads/test/unit/test_history_expiration.js
toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
toolkit/components/places/tests/cpp/places_test_harness.h

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

I am not very familiar code so I have just updated the js files.

Comment 2

[Raymond Lee [:raymondlee]]

(In reply to Raymond Lee [:raymondlee] from comment #1)
> Created attachment 703215 [details] [diff] [review]
> v1
> 
> I am not very familiar code so I have just updated the js files.
I mean cpp

Comment 3

[Marco Bonardo [:mak]]

Comment on attachment 703215 [details] [diff] [review]
v1

Review of attachment 703215 [details] [diff] [review]:
-----------------------------------------------------------------

please file a separate bug blocking bug 700250 to fix the cpp test.

::: toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
@@ +611,5 @@
>        os.removeObserver(observer, "cacheservice:empty-cache");
>        do_test_finished();
> +
> +      // Shutdown the download manager.
> +      Services.obs.notifyObservers(null, "quit-application", null);

please do this before invoking do_test_finished, just for coherence.

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

(In reply to Marco Bonardo [:mak] from comment #3)
> Comment on attachment 703215 [details] [diff] [review]
> v1
> 
> Review of attachment 703215 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> please file a separate bug blocking bug 700250 to fix the cpp test.

filed bug 832133

> 
> ::: toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
> @@ +611,5 @@
> >        os.removeObserver(observer, "cacheservice:empty-cache");
> >        do_test_finished();
> > +
> > +      // Shutdown the download manager.
> > +      Services.obs.notifyObservers(null, "quit-application", null);
> 
> please do this before invoking do_test_finished, just for coherence.

fixed

Comment 5

[Raymond Lee [:raymondlee]]

It looks good on try
https://tbpl.mozilla.org/?tree=Try&rev=bae122fbc758

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/87fe8d808537

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/87fe8d808537