Closed Bug 820763 Opened 10 years ago Closed 10 years ago

Stop using addvisit() in toolkit tests

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: mak, Assigned: raymondlee)

References

Details

Attachments

(1 file, 1 obsolete file)

The following tests are still using addVisit:

toolkit/components/places/tests/browser/browser_bug248970.js
toolkit/components/downloads/test/unit/test_history_expiration.js
toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
toolkit/components/places/tests/cpp/places_test_harness.h
Attached patch v1 (obsolete) — Splinter Review
I am not very familiar code so I have just updated the js files.
Assignee: nobody → raymond
Attachment #703215 - Flags: review?(mak77)
(In reply to Raymond Lee [:raymondlee] from comment #1)
> Created attachment 703215 [details] [diff] [review]
> v1
> 
> I am not very familiar code so I have just updated the js files.
I mean cpp
Comment on attachment 703215 [details] [diff] [review]
v1

Review of attachment 703215 [details] [diff] [review]:
-----------------------------------------------------------------

please file a separate bug blocking bug 700250 to fix the cpp test.

::: toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
@@ +611,5 @@
>        os.removeObserver(observer, "cacheservice:empty-cache");
>        do_test_finished();
> +
> +      // Shutdown the download manager.
> +      Services.obs.notifyObservers(null, "quit-application", null);

please do this before invoking do_test_finished, just for coherence.
Attachment #703215 - Flags: review?(mak77) → review+
(In reply to Marco Bonardo [:mak] from comment #3)
> Comment on attachment 703215 [details] [diff] [review]
> v1
> 
> Review of attachment 703215 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> please file a separate bug blocking bug 700250 to fix the cpp test.

filed bug 832133

> 
> ::: toolkit/forgetaboutsite/test/unit/test_removeDataFromDomain.js
> @@ +611,5 @@
> >        os.removeObserver(observer, "cacheservice:empty-cache");
> >        do_test_finished();
> > +
> > +      // Shutdown the download manager.
> > +      Services.obs.notifyObservers(null, "quit-application", null);
> 
> please do this before invoking do_test_finished, just for coherence.

fixed
Attachment #703215 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/87fe8d808537
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.