Closed Bug 820784 Opened 9 years ago Closed 8 years ago

Remove alternative add_task implementations

Categories

(Testing :: XPCShell Harness, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: mak, Assigned: raymondlee)

References

Details

Attachments

(1 file, 1 obsolete file)

Now that bug 819033 added native support to tasks, we can remove our own implementation of add_task.
there are 3 implementations currently in tree

http://mxr.mozilla.org/mozilla-central/search?string=function+add_task&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

one in Places, one in netwerk... I think they can just be removed, should be compatible. A trybuild may confirm that!
Component: Places → XPCShell Harness
Product: Toolkit → Testing
Summary: Remove Places add_task implementation → Remove alternative add_task implementations
Assignee: nobody → raymond
Status: NEW → ASSIGNED
Attached patch v1 (obsolete) — Splinter Review
I have removed the one in places and the other on in netwerk.   The one in testing is actually using Task.jsm so I just leave it as it is.

Submitted to try
https://tbpl.mozilla.org/?tree=Try&rev=d526364a9dad
Attachment #705788 - Flags: review?(mak77)
Attachment #705788 - Flags: review?(mak77) → review+
(In reply to Raymond Lee [:raymondlee] from comment #2)
> I have removed the one in places and the other on in netwerk.   The one in
> testing is actually using Task.jsm so I just leave it as it is.

yes the testing version is the good one but it arrived later to the party, so we had these local versions that now you are removing.
Attachment #705788 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f84ec5f29d3c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.