820784 - Remove alternative add_task implementations

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Marco Bonardo [:mak]]

Now that bug 819033 added native support to tasks, we can remove our own implementation of add_task.

Comment 1

[Marco Bonardo [:mak]]

there are 3 implementations currently in tree

http://mxr.mozilla.org/mozilla-central/search?string=function+add_task&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

one in Places, one in netwerk... I think they can just be removed, should be compatible. A trybuild may confirm that!

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: v1

I have removed the one in places and the other on in netwerk.   The one in testing is actually using Task.jsm so I just leave it as it is.

Submitted to try
https://tbpl.mozilla.org/?tree=Try&rev=d526364a9dad

Comment 3

[Marco Bonardo [:mak]]

(In reply to Raymond Lee [:raymondlee] from comment #2)
> I have removed the one in places and the other on in netwerk.   The one in
> testing is actually using Task.jsm so I just leave it as it is.

yes the testing version is the good one but it arrived later to the party, so we had these local versions that now you are removing.

Comment 4

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f84ec5f29d3c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f84ec5f29d3c