820803 - Introduce build/custom-settings.json, similar to custom-prefs.js but for settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Alexandre Poirot [:ochameau]]

As for preferences, we need to customize settings for development or for building custom images.
For now, we only support adding our own preferences through build/custom-prefs.js file. But in some cases, we need to tweak settings, like in bug 818884.

Here is a patch that search for build/custom-settings.json file and if exists, read it as JSON dictionnary and override default settings. This file looks like this:
{
  "devtools.debugger.remote-enabled": true
}

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Pull request 6974

Comment 2

[[:fabrice] Fabrice Desré]

Comment on attachment 691308 [details]
Pull request 6974

Very useful, thanks!

Comment 3

[Alexandre Poirot [:ochameau]]

Comment on attachment 691308 [details]
Pull request 6974

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
  Tested with and without this file, updated .gitignore in order to prevent it to be landed by error. Tested with wrong JSON syntax too, display meaningfull message.
Risk to taking this patch (and alternatives if risky):
  Low risk, can only break itself as it is encapsulated in try/catch statements.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 691308 [details]
Pull request 6974

That will make dev's life easier! Thanks.

Comment 5

[Alexandre Poirot [:ochameau]]

Landed:
https://github.com/mozilla-b2g/gaia/commit/7105b40d8e3ec3b79ffb31a889a1db1a907abb9d