820871 - GC: Validate gray marking

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

Currently gray marking is not validated along with black marking.  It would be nice if this happened too, if it's possible to do this without introducing test failures.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Proposed fix

Proposed fix.

Try build of this is actually looking good so far:

https://tbpl.mozilla.org/?tree=Try&rev=f641e9cc5f83

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 691363 [details] [diff] [review]
Proposed fix

Review of attachment 691363 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent!

::: js/src/jsgc.cpp
@@ +2716,5 @@
>  {
>      MarkWeakReferences<GCCompartmentGroupIter>(rt, phase);
>  }
>  
> +template <class CompartmentIter>

Again, can you call this CompartmentIterT?

Comment 3

[Jon Coppeard (:jonco)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/34840088cc10

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/34840088cc10