Closed
Bug 820871
Opened 13 years ago
Closed 13 years ago
GC: Validate gray marking
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
7.07 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Currently gray marking is not validated along with black marking. It would be nice if this happened too, if it's possible to do this without introducing test failures.
|
Assignee | |
Updated•13 years ago
|
Assignee: general → jcoppeard
|
|
Assignee | |
Comment 1•13 years ago
|
||
Proposed fix.
Try build of this is actually looking good so far:
https://tbpl.mozilla.org/?tree=Try&rev=f641e9cc5f83
Attachment #691363 -
Flags: review?(wmccloskey)
Comment on attachment 691363 [details] [diff] [review]
Proposed fix
Review of attachment 691363 [details] [diff] [review]:
-----------------------------------------------------------------
Excellent!
::: js/src/jsgc.cpp
@@ +2716,5 @@
> {
> MarkWeakReferences<GCCompartmentGroupIter>(rt, phase);
> }
>
> +template <class CompartmentIter>
Again, can you call this CompartmentIterT?
Attachment #691363 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•