820882 - Make TBPL recognize Android x86

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Kim Moir [:kmoir] ET]

We need to add "android-x86": "Android X86",

Right now we just want to run builds, not tests.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: patch

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 691955 [details] [diff] [review]
patch

Hi Kim - thank you for the patch (sorry was going to try to get to this later today/tomorrow, have just had a lot of things to get through). This part is fine, however you'll also need to change https://hg.mozilla.org/webtools/tbpl/file/055fdb84a753/js/Data.js#l497 , which matches the buildbot buildername against TBPL's internal name (in this case "android-2-2-x86").

The whole way TBPL does this is absolutely horrid I know :-( In TBPLv2 I hope we'll be able to tweak these via an admin panel or similar, to avoid pushing it to the UI & also needing production pushes every time. (Well and not using nested ternaries for a start).

Comment 3

[Ed Morley [:emorley]]

(Also note the repo has moved in the last 24 hours to https://hg.mozilla.org/webtools/tbpl/)

Comment 4

[Kim Moir [:kmoir] ET]

Attachment: patch

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 691966 [details] [diff] [review]
patch

lgtm, thanks :-)

Comment 6

[Kim Moir [:kmoir] ET]

I don't seem to have commit rights to this repo to push the patch

Comment 7

[Ed Morley [:emorley]]

(In reply to Kim Moir [:kmoir] from comment #6)
> I don't seem to have commit rights to this repo to push the patch

I believe it needs level 3 now, after the repo move.

I'm about to request a push to production, so landed this for you now so we can get this included :-)

https://hg.mozilla.org/webtools/tbpl/rev/5ddfe4061851

Comment 8

[Ed Morley [:emorley]]

In production :-)