82101 - Caret issues in a email message reply

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Andriy Palamarchuk]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9) Gecko/20010505
BuildID:    2001050515

In a reply message:
1) Cursor becomes huge, equal a height of the last quoted block when I go to the
end of the message with <Ctrl-End> keys combination. Also it goes on the right,
far after the quoted text.
2) In a state when the cursor is huge try to press <left>, <right> buttons, the
cursor goes to the beginning, end of the last quoted block without changing its
size.
3) Continue to press <left>, the cursor becomes of normal size and goes to the
symbol end of the text before the last quoted block. Note, it goes before the
last symbol.
4) When cursor in the middle of the reply message, press <right> button and keep
it. The cursor goes to the end of the message and disappears. Does not appear
again if I press <left> button.

Reproducible: Always
Steps to Reproduce:
1. Write to yourself an email message of the following contents (3 lines of 's'
symbol, 3 lines of 'r' without stars delimiter):
******************************
ssssssssssssssssssssssssssss
ssssssssssssssssssssssssssss
ssssssssssssssssssssssssssss
rrrrrrrrrrrrrrrrrrrrrrrrrrrr
rrrrrrrrrrrrrrrrrrrrrrrrrrrr
rrrrrrrrrrrrrrrrrrrrrrrrrrrr
******************************
Be sure you have the mail composer settings as I do (see below).
2. Receive the message.
3. Call reply to it - the compose window should appear.
4. Go with <Ctrl-End> to the end of the message, with <Shift-left> select all
the text below the quote, quoted empty lines, delete the block with <Del>
button. The cursor jumps to the beginning of the message (is it normal?).
5. Insert line 'mmmmmmmmmmmmmmmmm' between lines of 'r' and 's'. This will
simulate a reply text in the middle of a quoted block.
6. Press <Ctrl-End> button.
7. Press <left> button, press <right> button.
8. Press <left> button two times.
9. Press and keep <right> button some time, so the cursor goes throuh the end of
a quoted block.

Actual Results:  Step 6. You can see an issue (1).
Step 7. You can see an issue (2).
Step 8. You can see an issue (3).
Step 9. You can see an issue (4).

Expected Results:  Normal cursor moves in the boudaries of the quoted text.

My email composer has configuration to quote the text on reply and put reply
below the quoted message. I compose the message in plain text, not in HTML.
Mesage display: fixed width font, wrap text to window width turned on. Let me
know if you need my other email settings.

Comment 1

[Kathleen :Brade]

caret issue-->editor

Simon--you saw this the other day, did you file a bug on it?

Is this a duplicate?

Comment 2

[Simon Fraser [no longer active]]

This is caret whackiness around <pre>s. You see the same thing if you load a 
plain text file into composer, and hit command/up or command/down (on Mac).

I think the layout code that moves the selection around needs some more smarts 
for dealing with <pre>. -> mjudge

Comment 3

[mjudge]

ok i fixed "completeMove" to get this to work. this also has another benefit of 
fixing (or partialy) bug 52868 IMHO.

problem in just blindly grabbing body node and setting caret to body/offset X.  
we needed to use the methods that the mouse uses to figure out the more 
complicated scenarios of layout.

Comment 4

[mjudge]

Attachment: fix for "CompleteMove" in presshell

Comment 5

[kinmoz]

The 06/16/01 11:22 patch is also attatched to bug 52868 ... see that bug for 
comments/questions on the patch.

Comment 6

[mjudge]

fixed the uber carets around pre's

Comment 7

[sujay]

Ninoschka, can you try this out in latest build and see if it is fixed for you?

thanks...

Comment 8

[Andriy Palamarchuk]

I tested the issue on build 2001062021, Linux.
Everything works fine but I still could reproduce an issue when a caret becomes
huge (as in issue 1).

You can reproduce it with: 
Perform steps 1-3 as in previous description.
Then go to the end of line on the last 'r' line, press and keep <Del> key.
The caret becomes big when all the characters to the end of message are removed.

Comment 9

[sujay]

Andriy, I am marking this bug VERIFIED-FIXED....if you can open
a new bug for the problem you are describing regarding the caret
becoming big...thanks.

Comment 10

[Andriy Palamarchuk]

Agree. Posted bug 87634.
Thanks