821070 - bugmail sent by sanitycheck shows the wrong user as the changer

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[:glob ✱]

bugmail sent by sanitycheck shows the wrong user as the changer.

i triggered sanitycheck -> send unsent bugmail

the bugmail sent showed that i was the person who made the change:

> X-Bugzilla-Who: [e-mail]
> 
> https://bugzilla.mozilla.org/show_bug.cgi?id=707617
> Byron Jones ‹:glob› <[e-mail]> changed:
> Status|RESOLVED                    |VERIFIED

however this change was actually made by fox2mike

Comment 1

[:glob ✱]

evidently this is the best we can do:

# We cannot simply look at the bugs_activity table to find who did the
# last change in a given bug, as e.g. adding a comment doesn't add any
# entry to this table. And some other changes may be private
# (such as time-related changes or private attachments or comments)
# and so choosing this user as being the last one having done a change
# for the bug may be problematic. So the best we can do at this point
# is to choose the currently logged in user for email notification.

Comment 2

[Dave Miller [:justdave]]

Inline history manages to figure it out somehow.  I think the problem is the send_unsent tries to send one collective email for all changes since the last time mail was sent (which as mentioned, could have been done by more than one person).  It should instead step the last_sent date forward for each collection of changes it can find that have the same changer and timestamp, and send a new email for each chunk.

Comment 3

[Frédéric Buclin]

I suspect this could be fixed by bug 946565.

Comment 4

[Simon Green]

(In reply to Frédéric Buclin from comment #3)
> I suspect this could be fixed by bug 946565.

That would be correct. I was using sentunsentemail.pl when picking up this problem.

  -- simon

Comment 5

[Frédéric Buclin]

This is not exactly a duplicate, though the root cause is the same. The other bug is about mixing changers while this bug is about running sanitycheck.cgi and having the admin being taken as the changer despite he didn't change anything. (and technically, your bug is newer than this one, so the dupe link should be reversed.)

Comment 6

[Simon Green]

Blocker is now committed to trunk and 4.4.

  -- simon