821091 - Add a pref to make Marionette use force-local:true

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

Bug 800138 caused us to change how we open Marionette's listening socket.  On B2G, we went from force-local:true to force-local:false.  Unfortunately, this breaks gaia smoke tests on unagis (see bug 821084).

A possible workaround is to add a pref to control whether or not Marionette sets force-local:false before opening its socket.  It should default to setting this, so that panda testing works.  However, we should be able to override this with a pref that we can inject into /data/local/user.js or equivalent (in a Jenkins job, for instance).

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Add a pref to Marionette to cause it use force-local: true,

This allows us to fix the unagi test problems by setting the Jenkins job to push a file containing:

user_pref(marionette.force-local, true);

to /data/local/user.js before running the tests.  I'm going to land it only b2g18 only now, so it will be tomorrow's nightly, but will hold off on the other branches until reviewed.

Comment 2

[Jonathan Griffin (:jgriffin)]

Landed only on b2g18 for now, pending review: http://hg.mozilla.org/releases/mozilla-b2g18/rev/4df290e276b2

Comment 3

[Jonathan Griffin (:jgriffin)]

ah, mdas was fast :)

Comment 4

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/aac5a6c4024c

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aac5a6c4024c

Comment 6

[Jonathan Griffin (:jgriffin)]

Will, you'll probably need this workaround too for panda work once you update your gecko.  Due to bug 820617, Marionette isn't acting nicely on the panda.  To work around this, you can add the pref 'marioentte.force-local': true to the profile.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c1c3e6924008