Closed Bug 821101 Opened 10 years ago Closed 10 years ago

Contacts: Fix phonenumberJS error

Categories

(Core :: DOM: Device Interfaces, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20
blocking-basecamp +
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: gwagner, Assigned: gwagner)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #691582 - Flags: review?(bent.mozilla)
Comment on attachment 691582 [details] [diff] [review]
patch

Review of attachment 691582 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/fallback/ContactDB.jsm
@@ +270,5 @@
>                    debug("InternationalFormat: " + parsedNumber.internationalFormat);
>                    debug("InternationalNumber: " + parsedNumber.internationalNumber);
>                    debug("NationalNumber: " + parsedNumber.nationalNumber);
>                    debug("NationalFormat: " + parsedNumber.nationalFormat);
> +                  if (parsedNumber.internationalNumber && number.toString() !== parsedNumber.internationalNumber) {

Nit: I'd split this to two lines ;)
Attachment #691582 - Flags: review?(bent.mozilla) → review+
Duplicate of this bug: 820843
https://hg.mozilla.org/mozilla-central/rev/4dbff6dc7b50
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Comment on attachment 691582 [details] [diff] [review]
patch

[Triage Comment]
Attachment #691582 - Flags: approval-mozilla-b2g18+
Attachment #691582 - Flags: approval-mozilla-aurora+
Not blocking on this since no motivation was given why this bug is important. Feel free to renom with a motivation, or just uplift the patch since I just a+'ed it.
blocking-basecamp: ? → -
It can cause an Error in our ContactsDB code during importing or saving contacts and we never return from the request.
So it's impossible to save a contact or import contacts from the SIM card. 
Already seen in bug 820843.

E/GeckoConsole(  674): [JavaScript Error: "(intermediate value).internationalNumber is null" {file: "resource://gre/modules/ContactDB.jsm" line: 275}]
blocking-basecamp: - → ?
You need to log in before you can comment on or make changes to this bug.