Closed
Bug 821116
Opened 13 years ago
Closed 13 years ago
Track line numbers for XBL properties
Categories
(Core :: XBL, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(1 file)
|
3.09 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
It's really annoying when you get an error message that points you to line 0 of a thousand-line XBL file. This fixed the problem for me.
I have no idea who should review this code, but it's simple.
Attachment #691606 -
Flags: review?(bzbarsky)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 691606 [details] [diff] [review]
patch
Setting the line numbers will allocate getter/setter data structures even if they're not needed. I'd rather we added the line number as a constructor argument to nsXBLProtoImplProperty and did the sets where we call AppendGetter/SetterText in the constructor, at which point we know the line number is relevant.
r=me with that, and good catch!
Attachment #691606 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•