Closed Bug 821116 Opened 7 years ago Closed 7 years ago
Track line numbers for XBL properties
It's really annoying when you get an error message that points you to line 0 of a thousand-line XBL file. This fixed the problem for me. I have no idea who should review this code, but it's simple.
Attachment #691606 - Flags: review?(bzbarsky)
Comment on attachment 691606 [details] [diff] [review] patch Setting the line numbers will allocate getter/setter data structures even if they're not needed. I'd rather we added the line number as a constructor argument to nsXBLProtoImplProperty and did the sets where we call AppendGetter/SetterText in the constructor, at which point we know the line number is relevant. r=me with that, and good catch!
Attachment #691606 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.