Closed Bug 821123 Opened 7 years ago Closed 7 years ago

do not assume the first rooter has been scanned

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file)

Found a bug in my rooting analysis optimization. I was initializing the "firstScanned" rooter with the beginning of the list, which is bogus because many times no rooters at all will be scanned. Stupid bug.
I did it with an inelegant NULL check because I didn't want to deal with the stack growth direction, continuing the complete fiction that any of this would work with the stack growing the other way.
Attachment #691613 - Flags: review?(terrence)
Attachment #691613 - Flags: review?(terrence) → review+
Attachment #691613 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/20646e439eb7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Blocks: 745742
You need to log in before you can comment on or make changes to this bug.