Closed
Bug 821123
Opened 12 years ago
Closed 12 years ago
do not assume the first rooter has been scanned
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: sfink, Assigned: sfink)
References
Details
Attachments
(1 file)
|
2.22 KB,
patch
|
terrence
:
review+
sfink
:
checkin+
|
Details | Diff | Splinter Review |
Found a bug in my rooting analysis optimization. I was initializing the "firstScanned" rooter with the beginning of the list, which is bogus because many times no rooters at all will be scanned. Stupid bug.
|
Assignee | |
Comment 1•12 years ago
|
||
I did it with an inelegant NULL check because I didn't want to deal with the stack growth direction, continuing the complete fiction that any of this would work with the stack growing the other way.
Attachment #691613 -
Flags: review?(terrence)
|
||
Updated•12 years ago
|
Attachment #691613 -
Flags: review?(terrence) → review+
|
|
Assignee | |
Updated•12 years ago
|
Attachment #691613 -
Flags: checkin+
|
|
Assignee | |
Comment 2•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/20646e439eb7
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/20646e439eb7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•