821140 - nsIDOMWindowUtils APIs still say they require "UniversalXPConnect privileges", when they should say "chrome privileges"

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Daniel Holbert [:dholbert] (vacation until Jun 23)]

Bug 804174 changed nsDOMWindowUtils to replace a bunch of "IsUniversalXPConnectCapable()" checks with "IsCallerChrome()" checks.  It didn't update the documentation for those methods, though, so nsIDOMWindowUtils still has a bunch of documentation that mentions "UniversalXPConnect privileges".

I think all references to UniversalXPConnect in that IDL file should probably be replaced with references to "chrome privileges" (at least, for the functions that bug 804174 converted).

MXR link:
https://mxr.mozilla.org/mozilla-central/search?string=UniversalXPConnect&find=nsIDOMWindowUtils.idl&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central/base/nsIDOMWindowUtils.idl#83

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Update comments to say chrome privileges

Only comment updates

Comment 2

[Andrew McCreight [:mccr8]]

Comment on attachment 693010 [details] [diff] [review]
Update comments to say chrome privileges

Review of attachment 693010 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I'll fix the nit and land it.

::: dom/interfaces/base/nsIDOMWindowUtils.idl
@@ +617,5 @@
>     * Suppresses/unsuppresses user initiated event handling in window's document
>     * and subdocuments.
>     *
> +   * @throw NS_ERROR_DOM_SECURITY_ERR if called without chrome privileges and
> +   * NS_ERROR_FAILURE if window doesn't have a document.

nit: it looks like this should be indented.

Comment 3

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fbad4186f735

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fbad4186f735