Closed Bug 821178 Opened 7 years ago Closed 7 years ago

port browser_248970_a.js and browser_248970_b.js to the per-window PB APIs

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: andreshm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

(Removed these tests from per-window PB builds: https://hg.mozilla.org/integration/mozilla-inbound/rev/11965bca7513)
Assignee: nobody → andres
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/11965bca7513
Assignee: andres → ehsan
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Shoot, forgot to add [leave open] to the whiteboard...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Not sure why this is assigned to me!
Assignee: ehsan → andres
Attached patch Patch v1Splinter Review
The test browser_248970_a.js doesn't make sense anymore, since now the session store is always created, independently of the private window. 
The other test browser_248970_b.js was migrated to per window mode and it's running file locally.
Attachment #693146 - Flags: review?(josh)
Status: REOPENED → ASSIGNED
Attachment #693146 - Flags: review?(josh) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ce816b018b0a
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
(In reply to Ed Morley (Away 20th Dec-2nd Jan) [UTC+0; email:edmorley@moco] from comment #7)
> https://hg.mozilla.org/mozilla-central/rev/ce816b018b0a

     1.9  MOCHITEST_BROWSER_FILES += \
    1.10  	browser_248970_a.js \
    1.11  	browser_248970_b.js \
    1.12 ++	browser_248970_b_perwindowpb.js \
    1.13  	browser_354894.js \
    1.14  	browser_394759_privatebrowsing.js \
    1.15  	$(NULL)

That's one + too many there.
You need to log in before you can comment on or make changes to this bug.