821181 - Setting call waiting status only when user manually sets the value

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

See Bug 796824 comment 30: setting call waiting on bootup is failing a GCF test case. We shall rather let user manually set the call waiting status, instead of doing that automatically on bootup.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch

Don't set call waiting on bootup, wait for user manually setting.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> Created attachment 691712 [details] [diff] [review]
> Patch
> 
> Don't set call waiting on bootup, wait for user manually setting.

Hi Arthur,
This patch 1) removes setting call waiting on bootup 2) sets the value in settings DB back to the current one (null if we don't know) when setting fails.
Is this what you are expecting from the gaia side? Thanks :)

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

bb? because the issue fails a GCF test case. See comment 0.

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)
> (In reply to Hsin-Yi Tsai [:hsinyi] from comment #1)
> > Created attachment 691712 [details] [diff] [review]
> > Patch
> > 
> > Don't set call waiting on bootup, wait for user manually setting.
> 
> Hi Arthur,
> This patch 1) removes setting call waiting on bootup 2) sets the value in
> settings DB back to the current one (null if we don't know) when setting
> fails.
> Is this what you are expecting from the gaia side? Thanks :)
Thanks for Arthur's feedback. Per our discussion, I'll provide another patch that sets the value to null whenever the network notifies us a request error.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: Patch v2

Don't automatically set 'call waiting' on bootup.

Comment 6

[Andrew Overholt [:overholt]]

Certification failures are blockers.  If GCF isn't related to certification, please let us know and put the blocking flag back to ?.  Thanks.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Hi Anshul, 
This patch 'removing setting call waiting automatically on bootup' has been passed review. Could you please help verify if it revolves the GCF failure before I push it to m-c? Thank you :)

Comment 8

[Anshul]

Hsin-Yi, yes I tested that this change fixes the GCF test case faiure.

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/757dbace7953

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/757dbace7953

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4ebf351f134e
https://hg.mozilla.org/releases/mozilla-b2g18/rev/56a099c5eb4a