821244 - Inconsistency between the single selection pop-ups and multiple selection pop-ups on ICS and newer devices

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Adrian Tamas (:AdrianT)]

Firefox Mobile 18 beta 4 / Aurora 19.0a2 2012-12-12 / Nightly 20.0a1 2012-12-12
Samsung Galaxy Tab 2 7.0 (Android 4.0.4)

Steps to reproduce:
1) Open bugzilla.mozilla.org and go to advanced search
2) Tap on a multiple selection field
3) Close the pop-up and tap in a single selection field

Expected results:
Multiple and single selection pop-ups are consistent in design

Actual results:
The multiple selection pop-ups have white background and the single selection pop-ups have black background

Comment 1

[Aaron Train [:aaronmt]]

Those are native windows themed by the OS. Can you verify what you see is different on stock Android by using a Galaxy Nexus or a Nexus S or Nexus 7?

This is INVALID.

Comment 2

[Adrian Tamas (:AdrianT)]

The issue is reproducible as described also on a Galaxy Nexus running Android 4.1.1. On the Android Stock Browser both popups have a black background.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Adrian, can you take some screenshots?

Ian, is this what you think it should be?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I thought Wes and Sriram fixed other bugs like this in the past.

Comment 5

[Wesley Johnston (:wesj)]

To explain the problem, right now our App is using a dark theme, but light menus. To do that sriram added a default theme to list items that (for us) only affects some selects differently than others. So in some cases, we show a white background and in some a dark.

To fix this, I think we can just pass the HOLO_LIGHT theme when we create the AlertBuilder like I'm doing in the about:home customization code. I'll throw up a patch. But that means we'll still be using a dark theme but light menus. We should also just try flipping our default theme to light for everything. That's a separate, more risky patch.

Comment 6

[Sriram Ramasubramanian [:sriram]]

Somewhere in Ian's pipeline, he is restyling all the Dialog boxes (with/without lists in them).

Comment 7

[Wesley Johnston (:wesj)]

Good. The HOLO_LIGHT theme hack isn't going to work well because (I just remembered) it doesn't affect widgets on the text boxes. i.e. EditTexts and Checkboxes have white text and light colored icons. I don't want to override all that stuff.

I think we're better to just flip our theme.

Comment 8

[Ian Barlow (:ibarlow)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #6)
> Somewhere in Ian's pipeline, he is restyling all the Dialog boxes
> (with/without lists in them).

It's true. This is a work in progress of the design we're after http://cl.ly/image/0c3O1R1O2Q0l

Comment 9

[Adrian Tamas (:AdrianT)]

Attachment: single choice popup

Comment 10

[Adrian Tamas (:AdrianT)]

Attachment: multiple choice popup

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 12

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.