Closed Bug 821248 Opened 12 years ago Closed 12 years ago

We're not updating the text in Sms app after having created a contact from Sms (with an activity)

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-basecamp:+)

Status:
VERIFIED FIXED
Milestone:
B2G C4 (2jan on)
Project Flags:
blocking-basecamp +

People

(Reporter: whimboo, Assigned: borjasalguero)

References

Details

(Keywords: regression)

Attachments

(1 file)

PR
225 bytes, text/html
julienw
: review+
fcampo
: review+
Details
When you send messages to any contact and you go back to the message list pane only the numbers are shown. The name of contacts is not visible. Whenever a number is assigned to a contact the name has to be shown in the message list.
blocking-basecamp: --- → ?
Are you sure ? I can't reproduce. Be sure that you contacts have a name. And renominate if needed.
blocking-basecamp: ? → -
Flags: needinfo?(hskupin)
I cannot reproduce either.
Yes, I'm sure. Here some steps: 1. Add a contact after you have called the number the first time or received a call from this number 2. Open the messages pane 3. Click on '+' and type in the name of the person 4. Select the person 5. Write the message 6. Send the message and go back to the overview page After step 6 no name is shown but the phone number. Sounds like more QA members should have a look at.
blocking-basecamp: - → ?
Flags: needinfo?(hskupin)
Keywords: qawanted
Henrik: Not able to repro your bug using the unagi 12-13 nightly build. My contact name shows in the "Messages" Preview. I have a screenshot that I can upload if you want to see what I am seeing.
This time I can reproduce this bug.
This is not only happening in the list view but also for the message details pane. Adjusting summary. (In reply to dscravaglieri from comment #5) > This time I can reproduce this bug. Interesting. I wonder if one of the mentioned steps how the contact is created is causing this disconnect between messages and contacts.
Summary: Message (SMS) list doesn't show contact names → Message (SMS) app doesn't use contact names
blocking-basecamp: ? → +
Keywords: regression
Priority: -- → P2
Hi all! Could you add the info about Gaia&Gecko versions where it's reproducible? Thanks!
(In reply to Borja Salguero [:borjasalguero] from comment #7) > Hi all! Could you add the info about Gaia&Gecko versions where it's > reproducible? Thanks! Any change to get this without having to manually type this in here? Is there a command for adb or which file I would have to check?
Look in the sources.xml file (or default.xml) file in older builds to get this information - you can then cut and paste. (In reply to Henrik Skupin (:whimboo) from comment #8) > (In reply to Borja Salguero [:borjasalguero] from comment #7) > > Hi all! Could you add the info about Gaia&Gecko versions where it's > > reproducible? Thanks! > > Any change to get this without having to manually type this in here? Is > there a command for adb or which file I would have to check?
I'm not on those builds but the official nighlies for b2g. So my current build is 20121213 from Wednesday last week. After an update to yesterdays nightly build I still see this problem.
Assignee: nobody → fbsc
Target Milestone: --- → B2G C3 (12dec-1jan)
David, could you try with latest Gaia? Or If you like we could test with tomorrow Build (where all latest Gaia commits will be ready) and check if this error persist. Otherwise there are some issues with Contacts API (I've reopend this bug https://bugzilla.mozilla.org/show_bug.cgi?id=815833 ), so I would need more info from Gregor about it.
Not able to reproduce with the last build Gecko: 2aa138d Gaia: 2b77f0a.tgz
Given comment 12, WFM.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → WORKSFORME
This is not fixed for me. Before closing it again as WFM you should check first if you can reproduce in a build which has been proven to fail. As you can see in the early comments it might be hard. But please do. It's not that I want to have to reopen it each time someone can't reproduce.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Oh, and this has been tested with the build 20121218230200
Status: REOPENED → NEW
(In reply to Henrik Skupin (:whimboo) from comment #15) > Oh, and this has been tested with the build 20121218230200 Just guessing... Have you tried adding a new contact and see if the SMS app is using that contact information? Maybe even if you download the new build the contact database is not OK.
Looks like adding a new contact is doing the trick. So do I really have to recreate all of the contacts now? That would be a hassle for me given that we do not have any sync service active except Facebook. Any chance to get it upgraded? Also which changes to the database went in which fixed that problem? Do we have bug numbers for?
(In reply to Henrik Skupin (:whimboo) from comment #17) > Looks like adding a new contact is doing the trick. So do I really have to > recreate all of the contacts now? That would be a hassle for me given that > we do not have any sync service active except Facebook. Any chance to get it > upgraded? Also which changes to the database went in which fixed that > problem? Do we have bug numbers for? I don't know the answers for all these questions. Maybe some of the people copied on this e-mail can help you. Anyway, I think that this is part of the risk of a dogfooding program :(, maybe a b2gtestdriver can help you with this too. Marking as closed as it seems it is working for you now.
Status: NEW → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → WORKSFORME
I'm not sure about the fact that we should close it as WFM. At least not until the remaining question has been answered. Thing is that most likely bug 811538 fixed the problem which also has an auto-upgrade path which gets executed and should update the database to the new format. So I wonder if my database hasn't been updated or if missing contact names still can't be connected to a number. Gregor, given that you have worked on that feature (bug 811538) would you mind to give as the necessary information?
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Flags: needinfo?(anygregor)
I believe the problem lies in the movement of PhoneNumberJS from gaia to gecko. All new sms messages and all new contacts should be associated to the international version of the phone number. With the patch in bug 815833 we should also upgrade all your existing contacts. The SMS database upgrade is more tricky because we open the database during startup where we don't have the information about your current country. So for this we need bug 822528 which is close to landing. Once we have the knowledge about your current location we can perform the upgrade of the sms database. My guess is your bug will be fixed once all of this lands but you have to wait for the next updates.
Flags: needinfo?(anygregor)
Thanks Gregor. That sounds great. I will watch the upcoming versions for updates. Right now I'm running a build from today, so given that bug 815833 has been fixed two days ago and contacts still haven't been updated for me, I most likely have to wait for bug 815833 too. I will respond ASAP the fix is available and I can proof it fixes the problem.
Blocks: 811538
Status: REOPENED → NEW
Depends on: 815833, 822528
Keywords: qawanted
Gregor, also with both dependent bugs fixed the old entries with the phone number only in the messages application have not been updated. I still can't see the name of the contact.
Maybe this is a dupe of bug 821039?
I don't think so at least not while reading the comments of the other bug. Also I haven't imported any contact from Facebook.
this bug needs some movement. borja, if you're too busy for this please talk to gregor about it to see if he can help you...
Un-assigning from Borja, as based in comment 18 it works with a fresh build and hence I believe it is not something purely related with SMS.
Assignee: fbsc → nobody
I hit this on the first use of my phone, but since a full reset and an OTA update I can't repro it. What *might* be relevant is that on that first time when importing the contacts from the SIM, I exited before the import said it was complete (as I assumed it would continue anyway) - all my contacts did appear in the list, but never on SMS or incoming calls. Based on comment 20, I wonder if there was some final step that didn't complete after the import which could explain this? Either way, I can't repro it now :(
Assignee: nobody → fbsc
Hi all. I've tested and tested and Im gonna try to explain the issue here. Creating a contact from Contacts, and going to SMS App is working as expected. The only issue is while creating a contact FROM SMS App, using the activity. This is due to when an Activity is used, SMS App does not change the visibility (inline-activity it's an overlay, but the SMS App is behind), and SMS App is ready for re-check all contacts ONLY when a visibility change happens. Im gonna create a patch for the 'inline' activity scenario and I will deliver it asap!
Attached file PR —
Attachment #696984 - Flags: review?(felash)
Attachment #696984 - Flags: review?(fernando.campo)
I see the bug that borja is seeing but I suspect that it is not related to the original bug. I can't reproduce the original bug but a lot of things changed in the Sms app since then.
Yep, probably we should rename the bug... or create a new one, Wdyt?
David, it's true that this bug, at least as was described, it's not reproducible. I've created a path for a scenario that it's not the same of the original one, but it's true that we had a bug there. We could update the name of this bug and keep the patch here, or creating a new bug, closing this one and apply the patch to the new bug. Wdyt?
Flags: needinfo?(dscravaglieri)
Target Milestone: B2G C3 (12dec-1jan) → B2G C4 (2jan on)
Bugmorphing to reflect what we're doing now. The original bug is no more.
Flags: needinfo?(dscravaglieri)
Summary: Message (SMS) app doesn't use contact names → We're not updating the text in Sms app after having created a contact from Sms (with an activity)
Comment on attachment 696984 [details] PR Sorry for delay, I'm on PTO and have limited access to the web
Attachment #696984 - Flags: review?(fernando.campo) → review+
Status: NEW → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Comment on attachment 696984 [details] PR r=me
Attachment #696984 - Flags: review?(felash) → review+
This issue is fixed for device Unagi; build #20130113070202v.1, adding contact from receipt of sms updates previous messages from same number
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: